Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Hide "Add module to the dashboard" from Manager group #29372

Closed
Quy opened this issue Jun 1, 2020 · 3 comments
Closed

[4.0] Hide "Add module to the dashboard" from Manager group #29372

Quy opened this issue Jun 1, 2020 · 3 comments

Comments

@Quy
Copy link
Contributor

Quy commented Jun 1, 2020

Steps to reproduce the issue

Log in to the Administration backend as a manager.
Click Add module to the dashboard icon.

Actual result

You don't have permission to access this. Please contact a website administrator if this is incorrect.

@brianteeman
Copy link
Contributor

You identified the error but I think your solution is wrong.

The code says that this should be present
if ($user->authorise('core.create', 'com_modules'))

and a manager does have create access - however a manager does not have access to the admin interface

image

@chmst
Copy link
Contributor

chmst commented Jun 2, 2020

The condition must be <?php if ($user->authorise('core.manage', 'com_modules')) : ?> in com_cpanel default.php, not core.create .

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Jun 19, 2020
Applies the suggestion from @chmst to fix joomla#29372
@brianteeman
Copy link
Contributor

Please see #29718

@Quy Quy closed this as completed Jun 20, 2020
wilsonge pushed a commit that referenced this issue Jun 21, 2020
Applies the suggestion from @chmst to fix #29372
sakiss pushed a commit to sakiss/joomla-cms that referenced this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants