Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Check whether CSP is enabled and enabled by the current client #29601

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jun 14, 2020

Summary of Changes

Check whether CSP is enabled and enabled by the current client

Testing Instructions

  • Apply this PR
  • configure the CSP via the options in com_csp
  • check that the client filter (Site, Admin, both) works

image

Expected result

You can configure the CSP client

Actual result

You can not configure the CSP client

Documentation Changes Required

Yes: https://help.joomla.org/proxy?keyref=Help40:Components_CSP_Reports_Options && https://help.joomla.org/proxy?keyref=J4.x:Http_Header_Management

@zero-24 zero-24 added this to the Joomla 4.0 milestone Jun 14, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jun 14, 2020
@zero-24 zero-24 changed the title Check whether CSP is enabled and enabled by the current client [4.0] Check whether CSP is enabled and enabled by the current client Jun 14, 2020
@richard67
Copy link
Member

I have tested this item ✅ successfully on 9d01286

Works as expected:

@Quy
Copy link
Contributor

Quy commented Jun 14, 2020

I have tested this item ✅ successfully on 9d01286


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29601.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jun 14, 2020
@Quy
Copy link
Contributor

Quy commented Jun 14, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29601.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 14, 2020
@Quy Quy added the PR-4.0-dev label Jun 14, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Jun 14, 2020
@wilsonge wilsonge merged commit 195b562 into joomla:4.0-dev Jun 15, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Jun 15, 2020
@wilsonge
Copy link
Contributor

Thanks! Not sure whether this should be an option for the API or not. There should never be anything because it's json.... but given it's supposed to be a fail safe anyhow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants