Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Login page during installer doesnt allow hide/reveal password #29765

Closed
PhilETaylor opened this issue Jun 22, 2020 · 2 comments
Closed

[4.0] Login page during installer doesnt allow hide/reveal password #29765

PhilETaylor opened this issue Jun 22, 2020 · 2 comments
Labels
No Code Attached Yet

Comments

@PhilETaylor
Copy link
Contributor

Steps to reproduce the issue

Joomla 4
System -> Joomla (Update box)
Choose any file (#29763 bug allows any file)
Click upload and install

Expected result

Password hide/reveal icon is clickable like all other password boxes in Joomla 4

Actual result

Screenshot 2020-06-22 at 22 16 20
@brianteeman
Copy link
Contributor

Looks like it needs to use the WebAssetManager and useScript('field.passwordview')

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Oct 1, 2020
@brianteeman
[4.0] joomla update show password
1105375 
PR for joomla#29765

### Steps to reproduce the issue
Joomla 4
System -> Joomla (Update box)
Choose any file (joomla#29763 bug allows any file)
Click upload and install

### Expected result
Password hide/reveal icon is clickable like all other password boxes in Joomla 4
@brianteeman brianteeman mentioned this issue Oct 1, 2020
Merged
@brianteeman
Copy link
Contributor

Please test #30849

@zero-24 zero-24 closed this as completed Oct 1, 2020
zero-24 pushed a commit that referenced this issue Oct 2, 2020
@brianteeman
[4.0] joomla update show password (#30849)
4ed4395 
* [4.0] joomla update show password

PR for #29765

### Steps to reproduce the issue
Joomla 4
System -> Joomla (Update box)
Choose any file (#29763 bug allows any file)
Click upload and install

### Expected result
Password hide/reveal icon is clickable like all other password boxes in Joomla 4

* icon width
sakiss pushed a commit to sakiss/joomla-cms that referenced this issue Oct 16, 2020
@brianteeman @sakiss
[4.0] joomla update show password (joomla#30849)
fdd11c5 
* [4.0] joomla update show password

PR for joomla#29765

### Steps to reproduce the issue
Joomla 4
System -> Joomla (Update box)
Choose any file (joomla#29763 bug allows any file)
Click upload and install

### Expected result
Password hide/reveal icon is clickable like all other password boxes in Joomla 4

* icon width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PhilETaylor @brianteeman @zero-24 @joomla-cms-bot