-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] mod_syndicate a11y and more #30188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem 1. the alt text contains the word image which is not recommended 2. the alt text is hardcoded and not translatable 3. When the text is displayed then the alt text is not needed as it does not convey any meaning 4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link ### Solution 1. remove the alt text completely and replace with empty alt 2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely 3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on ### Testing If you dont already have a syndication module then create one The changes are visible in the config of the module #### Before #### After In the frontend the changes are only visible in the markup of the module #### After - with Label #### After - without label
Quy
reviewed
Jul 25, 2020
Co-authored-by: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on 6438a9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188. |
I have tested this item ✅ successfully on 6438a9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188. |
Thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* [4.0] mod_syndicate a11y and more ### Problem 1. the alt text contains the word image which is not recommended 2. the alt text is hardcoded and not translatable 3. When the text is displayed then the alt text is not needed as it does not convey any meaning 4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link ### Solution 1. remove the alt text completely and replace with empty alt 2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely 3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on ### Testing If you dont already have a syndication module then create one The changes are visible in the config of the module #### Before #### After In the frontend the changes are only visible in the markup of the module #### After - with Label #### After - without label * Update modules/mod_syndicate/tmpl/default.php Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Testing
If you dont already have a syndication module then create one
The changes are visible in the config of the module
Before
After
In the frontend the changes are only visible in the markup of the module
After - with Label
After - without label