Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] mod_syndicate a11y and more #30188

Merged
merged 2 commits into from
Jul 26, 2020
Merged

[4.0] mod_syndicate a11y and more #30188

merged 2 commits into from
Jul 26, 2020

Conversation

brianteeman
Copy link
Contributor

Problem

  1. the alt text contains the word image which is not recommended
  2. the alt text is hardcoded and not translatable
  3. When the text is displayed then the alt text is not needed as it does not convey any meaning
  4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link

Solution

  1. remove the alt text completely and replace with empty alt
  2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely
  3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on

Testing

If you dont already have a syndication module then create one

The changes are visible in the config of the module

Before

image

After

image

In the frontend the changes are only visible in the markup of the module

After - with Label

image

After - without label

image

### Problem
1. the alt text contains the word image which is not recommended
2. the alt text is hardcoded and not translatable
3. When the text is displayed then the alt text is not needed as it does not convey any meaning
4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link

### Solution
1. remove the alt text completely and replace with empty alt
2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely
3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on

### Testing
If you dont already have a syndication module then create one

The changes are visible in the config of the module
#### Before

#### After

In the frontend the changes are only visible in the markup of the module

#### After - with Label

#### After - without label
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jul 25, 2020
Co-authored-by: Quy <quy@fluxbb.org>
@particthistle
Copy link
Member

I have tested this item ✅ successfully on 6438a9a

Test successfully - results matched test instruction example results.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

@bonzani
Copy link

bonzani commented Jul 26, 2020

I have tested this item ✅ successfully on 6438a9a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30188.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 26, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jul 26, 2020
@Quy Quy merged commit ea2775c into joomla:4.0-dev Jul 26, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2020
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the syndicate branch July 26, 2020 17:00
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* [4.0] mod_syndicate a11y and more

### Problem
1. the alt text contains the word image which is not recommended
2. the alt text is hardcoded and not translatable
3. When the text is displayed then the alt text is not needed as it does not convey any meaning
4. When the text is not displayed then the use of the image as a link with an alt of feed-image does not convey the meaning of the link

### Solution
1. remove the alt text completely and replace with empty alt
2. when the text is not displayed give it a sr-only class so that the link has meaning instead of just removing it completely
3. as a result change some language strings and re-order the fields so that they make more sense and remove the show-on

### Testing
If you dont already have a syndication module then create one

The changes are visible in the config of the module
#### Before

#### After

In the frontend the changes are only visible in the markup of the module

#### After - with Label

#### After - without label

* Update modules/mod_syndicate/tmpl/default.php

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants