Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link A Link B Link C removal #30280

Open
webchun opened this issue Aug 5, 2020 · 26 comments
Open

Link A Link B Link C removal #30280

webchun opened this issue Aug 5, 2020 · 26 comments

Comments

@webchun
Copy link

webchun commented Aug 5, 2020

Steps to reproduce the issue

I have never used Link A Link B Link C when creating content, and when I really need it I think now we can use Custom Field.
Why don't we just remove it? I don't see any benefit to keep it and it might reduce confusion for new users/adopters. It also makes Joomla is simpler and easier to use.

screen shot 2020-08-05 at 04 17 06

Expected result

Actual result

System information (as much as possible)

Additional comments

@brianteeman
Copy link
Contributor

Just because you have never used it doesn't mean that other people do not. If it is removed what happens to the existing sitess that are using it

@astridx
Copy link
Contributor

astridx commented Aug 5, 2020

Brian is right. Simply removing it would not be good. On the other hand, it is good to clean up every now and then. Perhaps this is a compromise: we could mark the fields depreciated and only show them in the backend if they are filled. In this way, they can be changed but no new use is possible.

@coolcat-creations
Copy link
Contributor

Can't we migrate the fields to custom fields? Having a custom field Group Images and Links that show exactly that but can be deactivated?

@brianteeman
Copy link
Contributor

@coolcat-creations not going to be easy to do at all. I did have a PR to separate the "show images/links" param into "show images" and "show links" but it didnt gain any traction

@HLeithner
Copy link
Member

The next possible release for such change is J5, the only thing you can do is to "hide" them but I don't see any benefit for this.

You can move Links to it's own tab and hide it per default for new installations.

@coolcat-creations
Copy link
Contributor

I would welcome such change. The less unneeded stuff displayed, the better. But it would be great to have a link Custom field were you can enter an external or internal link. Internal link like file, menu item or article. Should I create a feature request?

@webchun
Copy link
Author

webchun commented Aug 5, 2020

Brian is right. Simply removing it would not be good. On the other hand, it is good to clean up every now and then. Perhaps this is a compromise: we could mark the fields depreciated and only show them in the backend if they are filled. In this way, they can be changed but no new use is possible.

This is the best option we have I think, I believe this small change can improve the UX for new adopters.
We probably will also get feedback, to know how many people actually use it before it totally be removed it in J5.

@universewrld
Copy link

universewrld commented Aug 5, 2020

@coolcat-creations not going to be easy to do at all. I did have a PR to separate the "show images/links" param into "show images" and "show links" but it didnt gain any traction

i think a good solution would be to create a "migrator" to transfer values from this field.

the same can be done with the "Images" field.

Now this tab is a duplicate of those fields that are in @joomla.

@brianteeman
Copy link
Contributor

Good luck creating that

@obuisard
Copy link
Contributor

obuisard commented Oct 8, 2020

There is more to it than just removing the fields and use custom fields instead.
If you want to remove Links A, B and C, the custom field of type URL also needs to be able to store a URL text and a target window, parameters which are desperately missing from the custom field. Loosing that info will not satisfy users.

@obuisard
Copy link
Contributor

obuisard commented Oct 8, 2020

While I am at it: getting links from the content table is 'straightforward' (through the 'urls' table column) while getting the custom fields for an article requires not so straightforward database requests. Basically, by using custom fields rather than Links A, B and C, we will be deteriorating performance.

@Llewellynvdm
Copy link
Member

The reality is it is not confusing, since those who know how to do the same with custom fields aren't new users, but has at least been around the block a few times. So I agree, if it is not broke, then don't fix it 👍

@ghost
Copy link

ghost commented Jan 28, 2021

Link A Link B Link C should be removed. They are confusing and duplicate

@brianteeman
Copy link
Contributor

@chnnst and how do you propose handling upgrades where they are being used?

@ghost
Copy link

ghost commented Jan 28, 2021

Link A Link B Link C should be removed. They are confusing and duplicate, no one should use them

@brianteeman
Copy link
Contributor

Stop and think for a second before posting and liking your own comments.

No matter what you think of these fields they exist in joomla 3 and people will have used them so if you remove them you have to have a means to handle that data on a site upgrade otherwise you will lose data and your site will be broken.

Think of everyone using joomla not just yourself

@ghost
Copy link

ghost commented Jan 28, 2021

Theus who use confusing and duplicate features can upgrade using extension or later if there will be need in j 4.1.

We need to ship j4 as soon as we can, with no need to introduce confusing and duplicate features.

Link A Link B Link C should be removed. They are confusing and duplicate, no one should use them.

@HLeithner
Copy link
Member

repeating the same message over and over again doesn't make it true, the last guy that did that got blocked on twitter, facebook, youtube, instagram and his own webshop. So please stop wasting our time with the same message.

@ghost
Copy link

ghost commented Jan 28, 2021

HLeithner joomla 4 is without release date and delayed. We need to ship joomla 4 as soon as we can, why you want to introduce confusing and duplicate features in joomla 4 ?

If you use joomla 3 with Link A Link B Link C you can upgrade later if there will be need using extension or in j 4.1 or j 5

Why not to do this?

@agi-code
Copy link
Contributor

As a new user, I see it like @chnnst.
Why not at least use #30280 (comment)

@brianteeman
Copy link
Contributor

Why not to do this?

Please think before you post. If you did you would realise why you are talking rubbish. This is NOT new. Have you ever used Joomla?

@HLeithner
Copy link
Member

@chnnst we do exactly this, we don't delay j4 and keep the behavior that exists at least 2011?

@ghost
Copy link

ghost commented Jan 28, 2021

HLeithner in my opinion introducing confusing and duplicate features in joomla 4 is bad design, but beter to discuss it couse it seems we have different opinions

#32179

@agi-code
Copy link
Contributor

@chnnst we do exactly this, we don't delay j4 and keep the behavior that exists at least 2011?

Who is we?

@HLeithner
Copy link
Member

you are so a funny person and you don't understand that this isn't an introduction because it already exsists. So I look this topic for now and can be unlocked at a later stage in the j5 dev process if needed.

@joomla joomla locked as too heated and limited conversation to collaborators Jan 28, 2021
@HLeithner
Copy link
Member

@agi-code 038d5c8 is the related commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests