[4.0] Remove quoting from ordering columns #30312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on ecd5605 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312. |
1 similar comment
|
I have tested this item ✅ successfully on ecd5605 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30312. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* Remove quoting from ordering columns * Remove redundant escaping * Fix ambiguous column names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30309.
Summary of Changes
Removes quoting from ordering columns since there could be multiple columns.
Remove unneeded escaped used on hardcoded values.
Fixes ambiguous column names.
Testing Instructions
Create
Articles - Latestin administrator.Set
OrdertoRecently Modified First.View the module in control panel.
Actual result BEFORE applying this Pull Request
Error:
Expected result AFTER applying this Pull Request
Works.
Documentation Changes Required
No.