-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert icon-trash to fas fa-trash #30468
Conversation
I have tested this item ✅ successfully on b2648c4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
I have tested this item ✅ successfully on b2648c4 Tested links: see #30464 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
I have tested this item ✅ successfully on 8028ea0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
Restarted drone |
Sorry, but if we take a closer look, we show that not all spaces are placed correctly yet, for example:
And so on.. [EDIT] |
I have tested this item ✅ successfully on 8028ea0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
Restarted drone |
|
@richard67 @infograf768 drone passing now. |
Back to Pending. This PR has to be tested again. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
I have tested this item ✅ successfully on a2d4a66 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
I have tested this item ✅ successfully on a2d4a66 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468. |
closing since we've merged it #30470 |
…Layout for iconclass (#30470) * 🎨 merge two equal JLayouts into one new JLayout * replace hard coded icon to call for JLayout * replace icon mapping to call for JLayout * add icon protected to layout * icon protected moved to jlayout iconclass * remove fas * add icon trash to mapping * add parameter to check if html should be rendered or icon class only * simplify php * replace massive if-then-elseif-then by switch * merge duplicate outcome fa-times * be consistent * simplify switch thx @Quy * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * remove setting icon to itself * copy changes from #30468 * change to use layout * Update libraries/src/HTML/Helpers/ActionsDropdown.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * use LayoutHelper in function * let default html output be true, instead of false * Update layouts/joomla/icon/iconclass.php I like this PHP7 operator Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Troy T. Hall <programming@hallhome.us> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Quy <quy@fluxbb.org>
…Layout for iconclass (joomla#30470) * 🎨 merge two equal JLayouts into one new JLayout * replace hard coded icon to call for JLayout * replace icon mapping to call for JLayout * add icon protected to layout * icon protected moved to jlayout iconclass * remove fas * add icon trash to mapping * add parameter to check if html should be rendered or icon class only * simplify php * replace massive if-then-elseif-then by switch * merge duplicate outcome fa-times * be consistent * simplify switch thx @Quy * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * copy changes from https://github.com/joomla/joomla-cms/pull/30468/files * remove setting icon to itself * copy changes from joomla#30468 * change to use layout * Update libraries/src/HTML/Helpers/ActionsDropdown.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * use LayoutHelper in function * let default html output be true, instead of false * Update layouts/joomla/icon/iconclass.php I like this PHP7 operator Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Troy T. Hall <programming@hallhome.us> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Quy <quy@fluxbb.org>
Pull Request for Issue # .
Summary of Changes
changes the trash icon in actions dropdown to "fas fa-trash"
Testing Instructions
apply pr.
inspect action dropdown "trash" icon.
verify icon class is "fas fa-trash"
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none