Undo/Redo for MediaManager Plugins #30510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @mbabker this PR replaces the existing script to generate the help toc.json file that is used to connect the help button in joomla to the help page on the docs site. Other than a few comment changes it is the same code that @mbabker posted. Before this PR then `php build\helpTOC.php` does not work After applying this PR then it runs successfuly and generates the toc.json file This PR includes an updated toc.json
Usually badges with counts are displayed with the count over the corner not by the side. As this is a scss change you need to `node build.js --compile-css` to test ### before ### after
Ensure that the language strings for the message titles are available to javascript and can be translated fixes joomla#29887 go to Install from URL tab leave the URL field blank Click Check and Install Note the alert at the top of the page: warning LowerCase W apply the patch and its now correct
* correct spelling, and rephrase sentence * Update ExceptionHandler.php
* several single icons found * eye close * eye * admin page title * $iconimage * sub-menu * icon-delete * mapping non same named. * reformat * Update administrator/templates/atum/scss/pages/_com_privacy.scss ty brian Co-Authored-By: Brian Teeman <brian@teeman.net> * refresh * refresh * remove * featured * featured * column sort icon * square * $displaydata * [class^='icon-'] * make fa-check green * com_contacts featured * more featured * more publish/unpublish * com_categories * newsfeeds * associations * $iconStates * fixed broken _icons.scss * icon-ban-circle * revert to icon-home per jm * revert to icon-home per jm * revert to icon-home per jm * [4.0][RTL] CSS logical properties init * Update _modals.scss * use margin-inline * Update _modals.scss * Revert "Update _modals.scss" This reverts commit eb0d8bb. * Revert "use margin-inline" This reverts commit 6b264dd. * Use margin-inline-end in atum's _header.scss * Fix CS from last commit in atum's _header.scss * working on joomla#28607 * working on joomla#28607 ugh * working on toolbar cross-reference missing from part 1 * icon-loop fix. * finder fix * more loop->sync changes * more loop->sync changes * puzzle -> puzzle-piece * puzzle -> puzzle-piece * joomla brand * address->file-alt * stack->copy * added more to star, such as default * removed blank line * equalizer->sliders-h * lightning->bolt * checkin->check-square * comments-2->comments * power-cord->plug * info-2->info-circle * generic not fixed * generic not fixed * workaround for generic * drone fix? * puzzle->puzzle-piece * per luca * match button icon-class to toolbar * chevron & publish * publish/unpublish star. NEEDS REVIEW! * publish/unpublish star. NEEDS REVIEW! * few more icons * more folders * conflict fix. * com_template->modals * modifed jgrid to handle known active classes * arrow-down3 -> caret-down * icon-checkedout -> fa-lock * icon-puzzle -> puzzle-piece * trying to fix drone * trying to fix drone * trying to fix drone * else if fix per quy * Update layouts/joomla/button/iconclass.php ty quy Co-authored-by: Quy <quy@fluxbb.org> * Update layouts/joomla/button/iconclass.php ty quy Co-authored-by: Quy <quy@fluxbb.org> * code format fix per quy * code formatting changes per @Quy * code formatting changes * articles toolbar icon * remove space before 'fas' * featured * com_contact * featured * preview = icon-eye -> fas fa-eye * workflows featured * added mapping for $inactive class * missing closing ?> * Increase Opacity of disabled Featured Icons * Change Icon Classes Add Font Awesome Regular to Atum Fix broken Icons after change * Update build/media_source/com_categories/js/shared-categories-accordion.es6.js ty sharky Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update build/media_source/system/js/fields/passwordview.es6.js ty sharky.. I suck @ js. Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update build/media_source/system/js/fields/passwordview.es6.js Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update layouts/joomla/toolbar/title.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/templates/atum/scss/template-rtl.scss Co-authored-by: Quy <quy@fluxbb.org> * pr joomla#29016 compatibility fix. * pr joomla#29016 compatibility fix. icon-default -> fa-home * Update FeaturedButton.php Add line break * Update FeaturedButton.php New line * Update FeaturedButton.php * Update FeaturedButton.php * removed stupid package-lock.json * b/c compatibility fix * b/c compatibility fix * Revert "b/c compatibility fix" This reverts commit 10c4611 * "b/c compatibility fix" * shelving * shelving * b/c compatability fix as found by jm. * phpcs fix * phpcs fix * phpcs fix * conflict fix. * conflict fix. * Revert "conflict fix." This reverts commit ef96c0f * Revert "conflict fix." This reverts commit 4aa7349 * removed improperly kept 133-147 Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: ciar4n <ciaran@joomla51.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: coolcat-creations <mail@coolcat-creations.com> Co-authored-by: SharkyKZ <sharkykz@gmail.com> Co-authored-by: infograf768 <infografjms@gmail.com>
Since the merge of joomla#28075 the icon is missing in the toolbar for joomla update ### Before  
* [4.0] com_redirect bulk import [a11y] Every input must have a label. This PR changes the text in the bulk import modal from a `<p>` to a `<label>` There is no visual change * typo
The dropdown menu for each mail template are all labelled by the same id and that id dows not exist. This PR correctly sets the aria-labelledby to use the unique id of the mail template
* Restore com_admin profile view * Restore language strings * Remove help site field * Simplify layout * Line length * Add return URL * Fix redirects * Move to src directory * Correct link * Fix TFA * Add back com_admin.profile context * CS * CS * CS Co-authored-by: Quy <quy@fluxbb.org> * Use com_users form * Restore string * Revert "Restore string" This reverts commit 7228688. * Revert "Use com_users form" This reverts commit da295c1. * Use com_admin form * Map com_admin.profile context * Missing strings * Rename strings * Missing string * Alpha sort * TFA switcher * Cleanup * Add password meter * Remove unused string Co-authored-by: Quy <quy@fluxbb.org>
the label had the wrong `for=` This pr corrects that so that the label is correctly marked to be for the select with th id batch-user-id code review should be ok
[4.0] Installation password length/meter
…tallation [4.0] Fix Alert multiple error display
* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested
…assiopea [4.0] [Cassiopea] Implementing Password length/meter
* fix * typo, (well nothing new) * Allow media fields in subforms - Cleanup Media field - Expose initilazation method of Bootstrpa Modlas to a Joomla.Bootstrap object - Initilise Modlas on the lifecycle of the Custom Element * Paleolithic js mode only in the legacy… * CS * Proper check * Pffff * Update joomla-field-media.w-c.es6.js
* make icon-circle use fa-circle * allows for including icon- in call
When we have fields displayed in columns with the label displayed above the input there is a width limit of 240px on the label. This results in long labels wrapping when it is not needed as the column is wider than 240px. In english we dont see this is many places but the easiest is in the __configure edit screen_ fields This simple PR changes the label width to 100% when the fields are displayed in columns like this. As this is an scss change you will need to `node build.js --compile-css` in order to test ### Before ### After
…30441) * [4.0] Add a parameter for back-to-top button in Cassiopeia Added a parameter to show / hide the back-to-top button in Cassiopeia. Currently the footer appears when a module has been published on position "footer". And the back-to-top only appears if the footer is visible. Since the footer is part of the grid, it is not easy to move the back-to-top outside the grid. Now it is possible to decide to have a back-to-top or not. If yes, the footer will be rendered showing the button, independently if there is a module in the position footer. It is also possible to show only modules (switch back-to-top off) or modules and back-to-top (switch on). * Added smooth scrolling Add smooth scrolling taking in account the preferences of the user (reduced motion). Improve language file. * Correct height and position of back-to-top button * Correct code style * Correct code style 2 * Change smooth scrolling behavior to take in account reduced motion preferences * Language file corrected, language string changed to match others * Update language/en-GB/tpl_cassiopeia.ini Link instead button Co-authored-by: Brian Teeman <brian@teeman.net> * Update templates/cassiopeia/scss/blocks/_global.scss Comment for smooth scroll Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Brian Teeman <brian@teeman.net>
…escription [4.0] Implementing display of fieldset descriptions for fieldset children
* [4.0] update helptoc Removes the string for the expired cache page that no longer exists and removes it from the index displayed on the left hand side in the help page * api
vlaucht
requested review from
laoneo,
rdeutz,
wilsonge and
zero-24
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Added Undo/Redo functionality for MediaManager Plugins.
All changes will be saved in a history, and can then be undone or redone with the buttons in the menu.
This could also be used to preserve the state of the plugin. As of now, if a change has been made and then the plugin is switched, the changes will be applied in a destructive way, and returning back to the plugin does not allow to return to the original state (For example: crop an image, switch to resize, go back to cropping and you will find, that it is not possible to extend the cropped area). The history stores the plugin state as well, and this could be used in a later PR to restore the state of the plugin.
I know that there are still some bugs in undo/redo if you switch between plugins, I will solve that tomorrow.
Testing Instructions
Edit an image in the MediaManager and click undo or redo in the menu to revert or redo the changes.