[3.x] Typo / Spelling BASIS #31362
Closed
[3.x] Typo / Spelling BASIS #31362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 68edb4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31362. |
|
@ceford As you have tested the other one for J4, can you test this one here for J3, too? Thanks in advance. |
|
Isn't removing strings a B/C break? |
|
Oh yes. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31362. |
|
Oops I forgot Closing |
|
Would it make sense to do this fix for J3, only not deleting the old language strings but marking with a deprecation comment line above them, telling to use the new ones, and adding the new language strings (new constants)? |
|
Dont think its worth it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes obvious typing/spelling error BASIS should be BASIC
code review
This is a 3.x version of #31361 - it has to be done as separate PR because just merging this one into 4 will not fix everything in 4