Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit offset to max len in com_search #31444

Merged
merged 1 commit into from Nov 21, 2020

Conversation

HLeithner
Copy link
Member

Pull Request for Issue #30501 .

Summary of Changes

Limit the offset length to textlength

Testing Instructions

Create a test side with short and long articles and search for a word using php 8

Actual result BEFORE applying this Pull Request

search error 0 mb_strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack)

Expected result AFTER applying this Pull Request

Get a search result

@bayareajenn
Copy link

I have tested this item ✅ successfully on 5affcda

After applying patch, com_search works with PHP8. Thanks Harald.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

@alikon
Copy link
Contributor

alikon commented Nov 21, 2020

I have tested this item ✅ successfully on 5affcda

php8 rc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

@joomla-cms-bot joomla-cms-bot removed PHP 8.x PHP 8.x deprecated issues PR-staging labels Nov 21, 2020
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.23 milestone Nov 21, 2020
@alikon
Copy link
Contributor

alikon commented Nov 21, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Nov 21, 2020
@richard67 richard67 added this to the Joomla! 3.9.23 milestone Nov 21, 2020
@richard67 richard67 merged commit 6316fc9 into joomla:staging Nov 21, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@richard67
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants