Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Favicons fixes #31512

Merged
merged 1 commit into from Nov 30, 2020
Merged

[4.0] Favicons fixes #31512

merged 1 commit into from Nov 30, 2020

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Nov 27, 2020

Pull Request for Issue #31508 .

Summary of Changes

Remove the hardcoded favicon from the templates manifests (atum + cassiopeia)

Testing Instructions

Try to copy a template

Actual result BEFORE applying this Pull Request

Missing favicon

Expected result AFTER applying this Pull Request

All good, you successfully cloned the template

Documentation Changes Required

A bit of documentation about the favicons:

  • The actual files are in media/system/images
  • Can be overridden by copying these files to templates\templateName\images\favicon**.(svg|ico)
  • Any updates will not affect your overrides (a popular question in the forum)

Things to note about the svg files:

  • the contents of the joomla-favicon can be replaced with any valid svg (the viewBox can be anything user defined)
  • the contents of the joomla-favicon-pinned can be replaced with any valid svg BUT the viewBox needs to remain viewBox="0 0 16 16"
  • The classic favicon.ico can be either 16x16 or 32x32

@ceford
Copy link
Contributor

ceford commented Nov 28, 2020

I have tested this item ✅ successfully on 7bbf37f

Applied patch and copied both templates successfully. Reviewed code too. Thanks for attending to this so promptly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

@ghost
Copy link

ghost commented Nov 28, 2020

I have tested this item ✅ successfully on 7bbf37f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Nov 28, 2020
@alikon
Copy link
Contributor

alikon commented Nov 28, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31512.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 28, 2020
@Quy Quy added the PR-4.0-dev label Nov 28, 2020
@richard67
Copy link
Member

System test failure in Drone seems not to be related to this PR. It seems to be a problem with our testing environment.

@laoneo laoneo merged commit 7807eaf into joomla:4.0-dev Nov 30, 2020
@laoneo
Copy link
Member

laoneo commented Nov 30, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Nov 30, 2020
@laoneo laoneo added this to the Joomla 4.0 milestone Nov 30, 2020
@dgrammatiko dgrammatiko deleted the 4.0-dev_favicons branch December 7, 2020 18:29
@dgrammatiko dgrammatiko mentioned this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants