Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #31508 .
Summary of Changes
Remove the hardcoded favicon from the templates manifests (atum + cassiopeia)
Testing Instructions
Try to copy a template
Actual result BEFORE applying this Pull Request
Missing favicon
Expected result AFTER applying this Pull Request
All good, you successfully cloned the template
Documentation Changes Required
A bit of documentation about the favicons:
media/system/images
templates\templateName\images\favicon**.(svg|ico)
Things to note about the svg files:
joomla-favicon
can be replaced with any valid svg (the viewBox can be anything user defined)joomla-favicon-pinned
can be replaced with any valid svg BUT the viewBox needs to remainviewBox="0 0 16 16"