[4.0] add missing interactivity #32168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2021
dgrammatiko
force-pushed
the
4.0-dev_atum_mobile
branch
from
66fd22c
to
ea80c6f
Compare
|
Does this PR also solve #32162 ? |
|
Yup, both. It's the same file so it didn't make any sense to do multiple PRs |
|
Maybe you could update testing instructions to that. I've already updated the 1st sentence "Pull Request for ...". |
I did already: |
|
This ones obvious on code review. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #32161 and #32162 .
Summary of Changes
Testing Instructions
Resize the browser to mobile size and try the bottom menu toggler
Try to edit an article and try the gears button on the top (mobile size again)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required