Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Missing images ? #32929

Closed
brianteeman opened this issue Mar 29, 2021 · 8 comments
Closed

[4.0] Missing images ? #32929

brianteeman opened this issue Mar 29, 2021 · 8 comments

Comments

@brianteeman
Copy link
Contributor

The images referenced in the css below do not exist. Not sure if this is a missing files problem or a bad css problem

/* System Standard Messages */
#system-message > .message > ul {
background-color: #c3d2e5;
background-image: url("../images/notice-info.png");
}
/* System Error Messages */
#system-message > .error > ul,
#system-message > .warning > ul,
#system-message > .notice > ul {
color: #c00;
}
#system-message > .error > ul {
background-color: #e6c0c0;
background-image: url("../images/notice-alert.png");
border-color: #de7a7b;
}
/* System Warning Messages */
#system-message > .warning > ul {
background-color: #e6c8a6;
background-image: url("../images/notice-note.png");
border-color: #fb0;
}
/* System Notice Messages */
#system-message > .notice > ul {
background-color: #efe7b8;
background-image: url("../images/notice-note.png");
border-color: #f0dc7e;
}

@richard67
Copy link
Member

Looks like either a copy and paste issue or an upmerge issue, or some old historical stuff from times when the Atum template was created.

Images with such names only exist in 3.x:

richard@vmkubu02:~/lamp/public_html/joomla-cms$ find ./ -type f -name "notice*\.png"
./administrator/templates/hathor/images/notice-alert.png
./administrator/templates/hathor/images/notice-note.png
./administrator/templates/hathor/images/notice-info.png
./templates/beez3/images/system/notice-alert.png
./templates/beez3/images/system/notice-note_rtl.png
./templates/beez3/images/system/notice-alert_rtl.png
./templates/beez3/images/system/notice-note.png
./templates/beez3/images/system/notice-info.png
./templates/beez3/images/system/notice-info_rtl.png
./media/system/images/notice-alert.png
./media/system/images/notice-note.png
./media/system/images/notice-info.png
./media/system/images/notice-download.png
richard@vmkubu02:~/lamp/public_html/joomla-cms$

In the 4.0-dev branch are no images with names like notice*.png.

@richard67
Copy link
Member

Hmm, no upmerge issue. This file joomla-cms/administrator/templates/system/scss/system.scss has been added with PR #31221 . => Ping @dgrammatiko .

@dgrammatiko
Copy link
Contributor

All these files are totally useless. I mean frames (not iframes!!!) are not supported anymore. Actually I was thinking to totally remove the system templates and patch the one place where these things are used (as fallbacks) with a prerendered html (as we re doing for the other hard fails)

@Fedik
Copy link
Member

Fedik commented Mar 30, 2021

This is from joomla 2.5, or even older 1.5
At that time we did not have layouts system. This style was loaded to keep styled "important parts" in fallbacks when the default template do not have index.php or component.php.

In joomla 4 the messages styles loaded with layout

Factory::getDocument()->getWebAssetManager()
->useStyle('webcomponent.joomla-alert')
->useScript('webcomponent.joomla-alert');

I think whole part with #system-message in system.css can be removed, or even whole system.css.

@Piyussshh
Copy link

@brianteeman I checked the images directory there were no such images named "notice-alert.png", "notice-note.png"

@brianteeman
Copy link
Contributor Author

@Piyussshh thats exactly what I said

@Piyussshh
Copy link

@Piyussshh thats exactly what I said
Then this is a missing file problem

@brianteeman
Copy link
Contributor Author

Closed as we have a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants