Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Spinner icon displays out of bound #32948

Closed
Quy opened this issue Mar 31, 2021 · 7 comments
Closed

[4.0] Spinner icon displays out of bound #32948

Quy opened this issue Mar 31, 2021 · 7 comments
Labels
No Code Attached Yet

Comments

@Quy
Copy link
Contributor

Quy commented Mar 31, 2021

Steps to reproduce the issue

Go to System > Language Overrides.
Select a Language & Client.
Click New button.
Click cursor in Search Text field.

Actual result

language-override
@ghost
Copy link

ghost commented Apr 3, 2021

Issue confirmed.

@RahulJha393
Copy link

I would like to fix this issue . Kindly guide where I can start from

@YatharthVyas
Copy link
Contributor

I was able to reproduce it but not consistently. I figured out that the issue has something to do with the span#refresh-status in /administrator/components/com_languages/tmpl/override/edit.php
I'd like to contribute to this. Could you please assign it to me

@ghost
Copy link

ghost commented Apr 6, 2021

@YatharthVyas you can make a pull request without an issue is assigned to you.

@YatharthVyas
Copy link
Contributor

YatharthVyas commented Apr 6, 2021 •
edited
Loading

I figured out and solved the issue in my local version. I solved this by making the following change:

Original
#refresh-status.show { display: grid; }

Modified
#refresh-status.show { display: block; }

I will be adding a more detailed explanation behind why this caused the bug in my PR.

This change was made in my /media folder which is added to .gitignore because I believe it's contents are installed using npm ci and composer install commands.

So, where exactly do I put my modified css files so that it reflects in the PR?

The files modified are:
media/com_languages/css/overrider.min.css
media/com_languages/css/overrider.css
build/media_source/com_languages/css/overrider.css

@infograf768
Copy link
Member

See here

joomla-cms/build/media_source/com_languages/css/overrider.css

Line 17 in 6d32e94

#refresh-status.show,

@YatharthVyas YatharthVyas mentioned this issue Apr 6, 2021
Merged
@Quy
Copy link
Contributor Author

Quy commented Apr 6, 2021

PR #33041. Thanks.

@Quy Quy closed this as completed Apr 6, 2021
drmenzelit pushed a commit that referenced this issue Apr 6, 2021
@YatharthVyas
[4.0] Fix Spinner Styling (#33041)
ad97c80 
* Fix spinner going out of bounds in com_languages

Issue: #32948

Original
`#refresh-status.show {
	display: grid;
}`

Modified
`#refresh-status.show {
	display: block;
}`

* [4.0] Fix spinner going out of bounds in com_languages 

Issue: #32948

Original
`#refresh-status.show {
	display: grid;
}`

Modified
`#refresh-status.show {
	display: block;
}`

* Update build/media_source/com_languages/css/overrider.css

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Quy <quy@fluxbb.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Quy @infograf768 @joomla-cms-bot @YatharthVyas @RahulJha393