Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Rename Web Services api-authentication plugins (See #31306) #33174

Merged
merged 4 commits into from
Apr 19, 2021

Conversation

particthistle
Copy link
Member

Pull Request for Issue #31306 (comment)

Summary of Changes

Rename the Basic Authentication and Token Authentication plugins to include Web Services in their plugin name and the plugin title.

Testing Instructions

  • Go to System > Plugins
  • Filter for api-authentication plugin type
  • View the plugin name (loaded from the .sys.ini files), as well as looking at the plugin settings to see the titles (from .ini files)

Actual result BEFORE applying this Pull Request

  • Plugin names will not have web services in them.
  • Plugin title on the plugin settings will not have web services in the title.

Expected result AFTER applying this Pull Request

  • Plugin names will have web services in them.
  • Plugin title on the plugin settings will have web services in the title.
    image

Documentation Changes Required

Not specifically. Web Services documentation is still to be comprehensively written, so when it is it will be incorporated in screen grabs and instructions at that time.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Apr 17, 2021
@ChristineWk
Copy link

I have tested this item ✅ successfully on fc023be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

@YatharthVyas
Copy link
Contributor

In #31306 (comment)
The suggested names are:

I think it would be better to name the plugins as:

  • API Authentication - Web Services Basic Auth
  • API Authentication - Web Services Joomla Token Auth

I believe the 'Auth' part is missing in the 2nd Plugin name, could you please confirm if this has been done intentionally or not?

@particthistle
Copy link
Member Author

@YatharthVyas intentionally.

Previous title was API Authentication - Joomla Token

The extra Auth is redundant IMO, as the Token is what's being configured by the plugin.

@YatharthVyas
Copy link
Contributor

I have tested this item ✅ successfully on fc023be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 18, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 18, 2021
@rdeutz rdeutz merged commit 3e62813 into joomla:4.0-dev Apr 19, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants