Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4][FTP Layer] use of is_writable when FTP Layer needed causes false error messages #33238

Closed
PhilETaylor opened this issue Apr 22, 2021 · 14 comments

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Apr 22, 2021

Steps to reproduce the issue

Install Joomla 4 on a server that requires the use of the FTP Layer (see #31857)

Go to Joomla Global Config and save

Expected result

When checking if folder paths are writable, consideration should be given to the FTP Layer status.

Global configuration is saved
Green feedback message

Actual result

ApplicationModel.php uses is_writable to check paths, which returns false (as FTP is needed to write to folders!)

if (!is_dir($path) || !is_writable($path))

Screenshot 2021-04-22 at 17 42 41

System information (as much as possible)

Additional comments

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

#33079 (comment)

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Dont waste your time

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

@PhilETaylor before you go any further can you see if any of this is possible in J3. I don't believe it is as it failed when I tried. If that is correct then its even more of a waste of time to implement something in J4 if no one is currently using it

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

I've put the FTP layer on the agenda for our JBS meeting tomorrow, and maybe our team lead can carry that to the PLT to discuss it there again.

@brianteeman
Copy link
Contributor

So another month delay then :(

@richard67
Copy link
Member

I want the opposite, I want to speed up decision and not cause another delay.

@richard67
Copy link
Member

I.e. nobody should wait for that. But we should soon re-evaluate if we really need to keep the FTP layer and drop it if we can.

@brianteeman
Copy link
Contributor

We have to wait. If the decision is to remove it then why waste time fixing something no one uses

@brianteeman
Copy link
Contributor

and its been on the release blocker list for 3 years

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants