-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Changed color of Joomlaversion #33726
Conversation
I have tested this item ✅ successfully on 5e15bbe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726. |
@sandramay0905 , please test again, Thanks |
I have tested this item ✅ successfully on ba38d4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726. |
@himanshu007-creator I am not sure if the new colours meet the contrast requirements for AA regarding a11y. |
Yes, I've just checked, contrast is AAA, and monochrome also still works. But I don't really see any advantage in this PR. |
@richard67 this patch helps to establish a sort of distinction for Joomlaversion . This separates it from other Header items as It only displays the current Joomla! version. |
I have tested this item ✅ successfully on ba38d4a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726. |
Well, colours are a matter of taste. I'm ok with this PR. I just don't want that we change colours forth and back because some people like this and others like that colour. I'll merge this now in the hope not to get issues or PRs about inconsistent colouring of the title bar. |
Pull Request for Issue # .
Summary of Changes
changed the color of joomlaversion on top. Earlier it had gray color,but not now
Testing Instructions
apply this patch, build the CSS and observe the joomlaversion
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required