Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Changed color of Joomlaversion #33726

Merged
merged 3 commits into from
May 12, 2021
Merged

[4.0] Changed color of Joomlaversion #33726

merged 3 commits into from
May 12, 2021

Conversation

himanshu007-creator
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

changed the color of joomlaversion on top. Earlier it had gray color,but not now

Testing Instructions

apply this patch, build the CSS and observe the joomlaversion

Actual result BEFORE applying this Pull Request

old

Expected result AFTER applying this Pull Request

new

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 10, 2021
@ghost
Copy link

ghost commented May 10, 2021

I have tested this item ✅ successfully on 5e15bbe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.

@himanshu007-creator
Copy link
Contributor Author

@sandramay0905 , please test again, Thanks

@ghost
Copy link

ghost commented May 10, 2021

I have tested this item ✅ successfully on ba38d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.

@richard67
Copy link
Member

richard67 commented May 10, 2021

@himanshu007-creator I am not sure if the new colours meet the contrast requirements for AA regarding a11y.

@brianteeman
Copy link
Contributor

No problem with contrast
image

@richard67
Copy link
Member

Yes, I've just checked, contrast is AAA, and monochrome also still works.

But I don't really see any advantage in this PR.

@himanshu007-creator
Copy link
Contributor Author

@richard67 this patch helps to establish a sort of distinction for Joomlaversion . This separates it from other Header items as It only displays the current Joomla! version.

@srishty-07
Copy link
Contributor

I have tested this item ✅ successfully on ba38d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.

@Quy
Copy link
Contributor

Quy commented May 10, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 10, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 10, 2021
@richard67
Copy link
Member

Well, colours are a matter of taste. I'm ok with this PR. I just don't want that we change colours forth and back because some people like this and others like that colour. I'll merge this now in the hope not to get issues or PRs about inconsistent colouring of the title bar.

@richard67 richard67 merged commit 91d093c into joomla:4.0-dev May 12, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants