Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Delete unused strings #33974

Merged
merged 1 commit into from
May 19, 2021
Merged

[4.0] Delete unused strings #33974

merged 1 commit into from
May 19, 2021

Conversation

Quy
Copy link
Contributor

@Quy Quy commented May 18, 2021

Testing Instructions

Code review.
Confirm that string constants are not being used.

@chmst
Copy link
Contributor

chmst commented May 19, 2021

I have tested this item ✅ successfully on 85bfc84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33974.

@himanshu007-creator
Copy link
Contributor

I have tested this item ✅ successfully on 85bfc84

These 2 String constants are not being used anywhere in code


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33974.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33974.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 19, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 19, 2021
@wilsonge wilsonge merged commit d7e37e8 into joomla:4.0-dev May 19, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 19, 2021
@Quy Quy deleted the workflow-strings branch May 19, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants