-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Change fa-fw to icon-fw #33980
Conversation
@Quy Sorry, maybe I make something wrong.
But I couldn't see the Private Messages buttons in the upper right corner. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980. |
It is hidden by default when there are no new private messages. To make it appear, please do the following in this file:
|
I have tested this item ✅ successfully on d24022c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980. |
OK now:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980. |
I trust if you are going to insist on this pointless change then you will be updating all the other instances in the admin. There is a valid reason to use a generic class in the frontend but none in the admin |
Nope. There are only 2 instances of |
Search again |
Well this PR makes these icons consistent with the other icons in the header. I am blind to what you are referring to so please enlighten me. |
I have tested this item ✅ successfully on d24022c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33980. |
sorry I was searching a branch of mine that had a lot of extensions installed and I didnt realise. There is only one fa- remaining
|
Mystery solved. I will do a PR for fa-8x. Thank you! |
Summary of Changes
To remove references to FontAwesome, use generic icon class.
Change fa-fw to icon-fw.
Change order for consistency.
Testing Instructions
Code review.
or
Log in to the administration area.
View Post Installation Messages/Private Messages buttons in the upper right corner.
Icons same before/after PR.