Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Unused strings in joomla.ini (admin / api / site) #34499

Closed
wants to merge 2 commits into from
Closed

[4.0] Unused strings in joomla.ini (admin / api / site) #34499

wants to merge 2 commits into from

Conversation

Kostelano
Copy link
Contributor

Summary of Changes

I am engaged in translation. Found a lot of unused constants in joomla.ini.

I delete them in the PR, then copy / paste to the API directory.

And added a constant for the AUTHOR meta tag, as using a generic constant is not a good idea. For example, in Russian, we translate all meta-tags "Метатег Robots", "Метатег Keywords" ... And suddenly, among the meta-data, there is just the line AUTHOR.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jun 13, 2021
@richard67
Copy link
Member

Are you sure that these strings are all not used? In some (rare) cases language constants are combined in code from parts, so you won’t find the complete language constant when searching for it.

@brianteeman
Copy link
Contributor

also please note I have personally never removed strings from joomla.ini as thats a generic language file that is used by extensions

@Kostelano
Copy link
Contributor Author

I know that part of a string is sometimes used, so I tested strings in a similar way. Of course, I would be glad if someone re-checks, but I think that everything is in order here.

As for other extensions, it is certainly impossible to guess here, but I do not think that many extensions use the lines of the main file. Besides, it is not a good idea to "reserve" a lot of unused lines of Joomla itself for some third-party extension, since the number of such lines will grow forever.

Here in the PR there are lines that were probably used back in Joomla 1.0 :).

@brianteeman
Copy link
Contributor

Here in the PR there are lines that were probably used back in Joomla 1.0 :).

Probably - even more reason that they are used elsewhere.

As for other extensions, it is certainly impossible to guess here, but I do not think that many extensions use the lines of the main file.

And that's a guess ;)

It took me 15 years to delete a string from specific language files.

@Kostelano Kostelano closed this Jun 14, 2021
@Kostelano Kostelano deleted the un-str-joomla-ini branch June 17, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants