[#33617] New option for redirect plugin: Collect URLs #3450
Conversation
|
JoomlaCode entry: [#33617] New option for redirect plugin: Collect URLs http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617 |
| @@ -5,3 +5,5 @@ | |||
|
|
|||
| PLG_REDIRECT_XML_DESCRIPTION="The system redirect plugin enables the Joomla Redirect system to catch missing pages and redirect users." | |||
| PLG_SYSTEM_REDIRECT="System - Redirect" | |||
| PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_LABEL="Collect URLs" | |||
| PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_DESC="This option disables the collection of URLs. This is useful to avoid unnecessary load on the database." | |||
There was a problem hiding this comment.
What do you think to say here: "This option controls the collection of URLs ...."?
|
tested patch successful with com_patchtester 👍 Thanks @Kubik-Rubik |
Changed language strings
|
@zero-24 Thanks for testing! Also changed the language strings according to your proposal. ;-) |
|
@Kubik-Rubik I like this 👍 |
brianteeman
added
Has JoomlaCode Tracker Item
and removed
Needs JoomlaCode Tracker Item
labels
Display message in the component about the option state "Collect URLs"
Kubik-Rubik
changed the title
|
Updated pull request with a notification message in the component for the new option "Collect URLs" in the plugin. The message is only displayed if the plugin is enabled. |
|
This has to wait till after the release of 3.3.0 since it introduces new language strings and we are currently in language freeze mode. |
|
This will have to be redone as it fails applying |
|
@infograf768 What exactly fails? Do have an error message? I used the Joomla! CodeSniffer file and the PHP Storm code styling file (by Matt Thomas). |
|
Apparently there is a conflct in some files and the PR can't be merged in current stage. You can rebase it to current staging and resolve the conflicts. |
Solved conflicts Solved conflicts Solved conflicts
|
@infograf768 Solved conflicts, should be able to be applied. |
|
Merged into 3.4-dev branch since it's a new feature. |
This pull request makes the collection of URLs optionally. This is useful to avoid unnecessary entries in the database.
JoomlaCode entry: [#33617] New option for redirect plugin: Collect URLs
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33617