Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add back "/libraries/vendor/bin" to folder deletion in script.php #34638

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jun 28, 2021

Pull Request for wilsonge#69 (comment) .

Summary of Changes

With PR #34289 folders /bin and /libraries/vendor/bin have been removed from the list of folders to be deleted on update in script.php because these folders might contain files or subfolders added by the site admin.

For /libraries/vendor/bin this was wrong because that folder is maintained by composer and completely cleared on the development environment when doing a composer install.

See also the comment here wilsonge#69 (comment) .

This PR here corrects this by adding that folder back.

As that folder has been removed from the installation and update packages with 4.0 RC 1, the folder is added back to section 4.0 from Beta 7 to RC 1 like it was before PR #34289 .

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

No folder /libraries/vendor/bin in section 4.0 from Beta 7 to RC 1 of the $folders array in method deleteUnexistingFiles of file administrator/components/com_admin/script.php.

Expected result AFTER applying this Pull Request

Folder /libraries/vendor/bin in section 4.0 from Beta 7 to RC 1 of the $folders array in method deleteUnexistingFiles of file administrator/components/com_admin/script.php.

Hint: Folders within a version specific section are ordered reverse alphabetical.

Documentation Changes Required

None.

@Fedik
Copy link
Member

Fedik commented Jun 28, 2021

I have tested this item ✅ successfully on cbb7e62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

1 similar comment
@wojsmol
Copy link
Contributor

wojsmol commented Jun 28, 2021

I have tested this item ✅ successfully on cbb7e62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34638.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 28, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Jun 28, 2021
@wilsonge wilsonge merged commit 4e02899 into joomla:4.0-dev Jun 29, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 29, 2021
@richard67
Copy link
Member Author

Thanks all.

@richard67 richard67 deleted the 4.0-dev-script-php-deleted-files-libraries-vendor-bin branch June 29, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants