[4.0] Alerts custom element redo

[dgrammatiko]

Redo of Pull Request #33234 .

This one should be treated as Release Blocker

(The alert code wasn't production-grade...)

Summary of Changes

The Alert Custom Element had some known issues and this PR is pulling a version that fixes all of them joomla-projects/custom-elements#179

Testing Instructions

Go to front end and backend and check that alerts are functioning as before (there are no styling changes, although the source is using CSS Vars for almost all parameters)

You can fire an alert using the browser's console with these snippets:

// Danger
Joomla.renderMessages({danger: ['Something happen']})
// Warning
Joomla.renderMessages({warning: ['Something happen']})
// Success
Joomla.renderMessages({success: ['Something happen']})
// Info
Joomla.renderMessages({info: ['Something happen']})

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

The way that messages are rendered is exactly the same (only one internal change, not exposed to the API), so there is not anything to document.

@wilsonge DO NOT MERGE THIS WITHOUT MERGING THE OTHER PR CREATE A RELEASE AND CHANGE THE PACKAGE.JSON TO USE A VERSION!!!!

[richard67]

@dgrammatiko Npm still fails in drone.

Update: Would not be a problem as such because composer.lock will be updated anyway later when a new release has been made of custom_elements, but the failing npm causes other tests like the system tests not to run, so if it is possible to fix it, it would help with that.

[dgrammatiko]

Npm still fails in drone.

I saw that but I have no other tricks here (we need to install an npm package using git but for some reason, the drone script doesn't support that). If you know another way please edit the packge.json directly

PS it should be the same reason why the other PR for the SCSS compiler also failed (spawn... )

PS it turns out that drone is using the node alpine container which doesn't have git (https://github.com/nodejs/docker-node/blob/fd130acf063b312355a5d88d51716db3ff34ae49/14/alpine3.11/Dockerfile)... I can propose a docker container based on node 14 alpine with git, this will probably solve the problem here but also in #33170

[wilsonge]

Do we not need the close-text attribute on the hardcoded alert elements around core?

[dgrammatiko]

Are there any hard coded custom elements? If so yes, it's for a11y

@wilsonge there is only one instance with dismiss attribute and now it's also patched

[wilsonge]

I have tested this item ✅ successfully on 2c92281

Navigated around the logins, stats plugin alert and javascript generated alerts (e.g. when trying to save an article with no title). All seemed fine afterwards

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34781.}

[wilsonge]

Thanks!

[dgrammatiko]

Thanks!