New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverse order of modulpositions #3569
Conversation
What is the purpose of this Pull Request. What are you trying to achieve? What is the problem you are trying to solve. |
I render dependent modules to different positions. Now it would be the item with a newer date would stand at the bottom of the page. |
Thanks for adding that
|
This PR has the potential to cause weird and difficult to diagnose issues with some existing sites. The order in which modules are executed would be changed and hence, potentially, this could change the order in which JavaScript or CSS assets are loaded in the head. |
@chrisdavenport are you saying therefore that we need to close (reject) this PR for b/c reasons This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569. |
Yes, it could potentially break a (probably) small number of existing sites which depend on a specific load order. This is why the reverse load order, which probably originated in Mambo, has been preserved. I'm not saying this is a bad idea, just that it can't be done before 4.0 at the earliest. |
Closing because of the B/C issue This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569. |
@brianteeman can you add the |
..I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a variable. So the next module the item stored with do not append.
Now it would be the item with a newer date would stand at the bottom of the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the first five would be below and above the last.