Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse order of modulpositions #3569

Closed
wants to merge 1 commit into from
Closed

reverse order of modulpositions #3569

wants to merge 1 commit into from

Conversation

nielsnuebel
Copy link
Contributor

..I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the first five would be below and above the last.

@brianteeman
Copy link
Contributor

What is the purpose of this Pull Request. What are you trying to achieve? What is the problem you are trying to solve.

@nielsnuebel
Copy link
Contributor Author

I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the first five would be below and above the last.

@brianteeman
Copy link
Contributor

Thanks for adding that
On 17 Oct 2014 07:39, "Niels Nübel" notifications@github.com wrote:

I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a
variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of
the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the
first five would be below and above the last.


Reply to this email directly or view it on GitHub
#3569 (comment).

@chrisdavenport
Copy link
Contributor

This PR has the potential to cause weird and difficult to diagnose issues with some existing sites. The order in which modules are executed would be changed and hence, potentially, this could change the order in which JavaScript or CSS assets are loaded in the head.

@brianteeman
Copy link
Contributor

@chrisdavenport are you saying therefore that we need to close (reject) this PR for b/c reasons


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569.

@chrisdavenport
Copy link
Contributor

Yes, it could potentially break a (probably) small number of existing sites which depend on a specific load order. This is why the reverse load order, which probably originated in Mambo, has been preserved. I'm not saying this is a bad idea, just that it can't be done before 4.0 at the earliest.

@brianteeman brianteeman closed this Jan 2, 2015
@brianteeman
Copy link
Contributor

Closing because of the B/C issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569.

@zero-24
Copy link
Contributor

zero-24 commented Jan 2, 2015

@brianteeman can you add the Reevaluate for v4.0 label? As per comment by @chrisdavenport

@zero-24 zero-24 modified the milestone: Joomla 4.0 Aug 24, 2015
@zero-24 zero-24 modified the milestone: Joomla 4.0 Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants