Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'show_search_form' param does not exist in com_finder #35692

Closed
sakiss opened this issue Sep 28, 2021 · 5 comments
Closed

'show_search_form' param does not exist in com_finder #35692

sakiss opened this issue Sep 28, 2021 · 5 comments

Comments

@sakiss
Copy link
Contributor

sakiss commented Sep 28, 2021

Steps to reproduce the issue

Check the file: components/com_finder/tmpl/search/default.php

There is that code:

<?php if ($this->params->get('show_search_form', 1)) : ?>
      <div id="search-form" class="com-finder__form">
	      <?php echo $this->loadTemplate('form'); ?>
      </div>
<?php endif; ?>

Though a param with the name show_search_form does not exist in com_finder.
If you are familiar with grep search, you can search the entire Joomla installation, to confirm that.

Expected result

To exist a param with that name in the component's config xml or in the menu item xml

Actual result

Not found

System information (as much as possible)

Joomla 4.0.3

Additional comments

@brianteeman
Copy link
Contributor

even joomla 3 has this code and doesnt have a parameter

@sakiss
Copy link
Contributor Author

sakiss commented Sep 29, 2021

Shouldn't get fixed, though?

@brianteeman
Copy link
Contributor

of course it should

@brianteeman
Copy link
Contributor

please test #35967

@richard67
Copy link
Member

Closing as having a pull request. Please test #35967 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants