[4.0] php memory limit #35854
[4.0] php memory limit #35854
Conversation
It is possible to set the memory limit in php to -1 which means unlimited memory. Unfortunately this was not accounted for in the maths to check if a file could be uploaded. To test you will need to change the value in your php.ini to `memory_limit = -1` and restart the web server. Then try to upload any file in the media manager and you will see an error message that the file is too large. Apply this PR and the upload will be successful. PR for joomla#35853
|
I have tested this item ✅ successfully on 43ccd32 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854. |
administrator/components/com_media/src/Controller/ApiController.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 6f34162 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854. |
|
@rjharishabh Could you test again? Thanks in advance. |
|
I have tested this item ✅ successfully on 6f34162 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35854. |
| @@ -158,13 +158,13 @@ public function getItems() | |||
| 'description' => Text::_('COM_INSTALLER_MSG_WARNINGS_UPLOADBIGGERTHANPOSTDESC')); | |||
| } | |||
|
|
|||
| if ($post_max_size < $minMemory) | |||
| if ($post_max_size < $minMemory && $memory_limit != -1) | |||
There was a problem hiding this comment.
Is this check correct? Does unlimited memory_limit make PHP to ignore post_max_size & upload_max_filesize?
There was a problem hiding this comment.
it is the same as other checks in the same file - it was just missing here
There was a problem hiding this comment.
If I see it correct, they are different checks, the other which exist looking for the memory_limit, the two you changed are checking the `` post_max_sizeandupload_max_size```
There was a problem hiding this comment.
All I can say is that I replicated the reported problem and this change resolved the reported problem
There was a problem hiding this comment.
Sure it was the changes in this file here which solved it, i.e. the change in the other file below was not enough?
I tried visual code on github and completely failed... so I write it down here. Benjamin is right your changes to $post_max_size and $upload_max_filesize is wrong, you have to check this 2 variables to be bigger then 0 (not -1). also you have to add this check to the ApiController, because it's possible to set the upload size and post size to -1 or 0 (both unlimit) |
|
I’ve re-opened the issue. |
It is possible to set the memory limit in php to -1 which means unlimited memory.
Unfortunately this was not accounted for in the maths to check if a file could be uploaded.
To test you will need to change the value in your php.ini to
memory_limit = -1and restart the web server.Then try to upload any file in the media manager and you will see an error message that the file is too large.
Apply this PR and the upload will be successful.
PR for #35853