Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] No Articles Message #35894

Merged
merged 2 commits into from
Nov 2, 2021
Merged

[4.0] No Articles Message #35894

merged 2 commits into from
Nov 2, 2021

Conversation

brianteeman
Copy link
Contributor

Both category blog and category list have an option to show or hide a message if there are no articles in the category.

Before this PR the option worked only for a category blog. It was not possible to hide the message for a category list.

In addition the message, when displayed, was not formatted consistently. In some places it was a simple paragraph, in others it was a nicely formatted message. This PR makes the messages display consistently.

image

Pull Request for #35885

Both category blog and category list have an option to show or hide a message if there are no articles in the category.

Before this PR the option worked _only_ for a category blog. It was not possible to hide the message for a category list.

In addition the message, when displayed, was not formatted consistently. In some places it was a simple paragraph, in others it was a nicely formatted message. This PR makes the messages display consistently.
@ceford
Copy link
Contributor

ceford commented Oct 27, 2021

I looked at #35885 but could not figure out exactly how to test. Any chance of some instructions for simpletons like me?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35894.

@brianteeman
Copy link
Contributor Author

Create a category
Create a subcategory
Add an article to the subcategory

Create a menu item List Category to the parent category
Set the options as shown in #35885

@richard67
Copy link
Member

I have tested this item ✅ successfully on 9718bd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35894.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Oct 28, 2021

I have tested this item ✅ successfully on 9718bd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35894.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35894.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 28, 2021
@bembelimen bembelimen merged commit 0c48c5e into joomla:4.0-dev Nov 2, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 2, 2021
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.0.5 milestone Nov 2, 2021
@brianteeman
Copy link
Contributor Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants