[3.10] [PHP 8.1] deprecated header() in WebApplication #36728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
reviewed
Jan 18, 2022
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
This comment was marked as abuse.
This comment was marked as abuse.
That zero-chars replacement is already in Joomla 3.10, even written cleaner, as a separate line: |
This comment was marked as abuse.
This comment was marked as abuse.
|
No worries, checked before committing too to make sure that security-wise we're fine! 😉
|
|
Will take this for 3.10.6 thanks @beat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fixes PHP 8.1 deprecation warning in Joomla 3.10.
Note in Joomla 4.0: Same PHP 8.1 deprecated issue is in libraries/vendor/joomla/application/src/AbstractWebApplication.php line 886 but it doesn't appear.
Testing Instructions
Use PHP 8.1 in Joomla 3.10
Enable debug mode (without Debug plugin enabled!) (not sure if CB also imight be needed to reproduce).
Go to administration home page
Actual result BEFORE applying this Pull Request
Deprecated: header(): Passing null to parameter #3 ($response_code) of type int is deprecated in libraries/src/Application/WebApplication.php on line 1101Expected result AFTER applying this Pull Request
No warning.
Documentation Changes Required
None.