Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1 Scheduled Tasks] Image path does not exist #36735

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[4.1 Scheduled Tasks] Image path does not exist #36735

merged 2 commits into from
Jan 25, 2022

Conversation

Kostelano
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Create an image resizing task, select any directory you like. Then change the title of the directory you chose. Run the task. It's strange that when it's finished, we won't be told anything in the modal window, but we'll get a warning in the log file that the path to the image exists, which is not true.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Jan 18, 2022
@richard67
Copy link
Member

The changed language string is used here: https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/task/checkfiles/checkfiles.php#L86-L91 :

		if (!Folder::exists($path))
		{
			$this->logTask(Text::_('PLG_TASK_CHECK_FILES_LOG_IMAGE_PATH_NA'), 'warning');

			return TaskStatus::NO_RUN;
		}

So from code review it's clear that this PR here is right.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 9e8a6a5

Code review. It's obvious that this PR is right, details see in my previous comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

@Quy
Copy link
Contributor

Quy commented Jan 18, 2022

I have tested this item ✅ successfully on 9e8a6a5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

@Quy Quy removed the Language Change This is for Translators label Jan 18, 2022
@Quy
Copy link
Contributor

Quy commented Jan 18, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

@Quy Quy added the Language Change This is for Translators label Jan 18, 2022
@richard67 richard67 removed the Language Change This is for Translators label Jan 18, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2022
@Quy Quy removed the RTC This Pull Request is Ready To Commit label Jan 18, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36735.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2022
@richard67 richard67 added the Language Change This is for Translators label Jan 18, 2022
@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Jan 20, 2022
@bembelimen bembelimen modified the milestones: Joomla 4.1.1, Joomla 4.1.0 Jan 25, 2022
@bembelimen bembelimen merged commit 0c2546c into joomla:4.1-dev Jan 25, 2022
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants