Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix open_basedir warning when creating a menu item #36791

Merged
merged 2 commits into from Jan 25, 2022

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 22, 2022

Pull Request for Issue #36788 and #35895 .

Summary of Changes

Correctly check path. Same as #36789

Testing Instructions

Follow #36788 and #35895

Actual result BEFORE applying this Pull Request

A warning about open_basedir stuff

Expected result AFTER applying this Pull Request

No warning

Documentation Changes Required

None

@ChristineWk
Copy link

Thank you @Fedik
For J 3 = OK. (36789)
For J 4 = (Patchtester) got Message:
404RuntimeException
Invalid Issue

@ChristineWk
Copy link

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36791.

@richard67
Copy link
Member

I see that @ChristineWk could not mark her test result because the "Test this" button is missing in the issue tracker. A problem which we sometimes have for (yet) unknown reasons. Maybe it will appear later, we will see.

@richard67
Copy link
Member

I have also tested with success. Still no "Test this" button for this PR in the issue tracker, but it has 2 human tests so I set it RTC (if that will work at least).

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36791.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 23, 2022
@richard67 richard67 added this to the Joomla 4.1.0 milestone Jan 23, 2022
@bembelimen bembelimen merged commit 38a974d into joomla:4.1-dev Jan 25, 2022
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 25, 2022
@Fedik Fedik deleted the fix-menu-error4 branch January 25, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants