-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[4.1] Add server timing response header in debug mode (#36231)" #36840
Conversation
Also can just change |
I do not agree. It uses the dispatcher which is new way. So should an empty event being introduced here or what? |
We have RFC for versioning joomla/rfc#29 (though it still RFC)
New Event add a new public API, so it a new feature 😉 |
@Fedik please read the sentence again. This is not a signature change! And it is a about patch releases and does not mention in any way RC. |
Correct, but a new public API. |
Actually I do not care which event is used. If there is an existing one, then this pr can change to it and revert the "new" event. But reverting a whole pr which adds some debug functionality is just ridiculous. |
Then make a pr which uses your suggested event and all is good. I will immediately test it. |
Actually the original PR fixes a missing event ( So I revert my opinion on reverting this PR since the event already exists, only the PR doesn't do what would be expected if the page is full cached because of the missing |
Keep in mind, this is only something which should work in debug mode and hopefully the caching plugin is not running when debugging. |
actually it does, looking at the code it also triggers the |
Wouldn't expect that... |
This reverts commit 360409f.
Summary of Changes
Sorry, was to fast in merging. We should for new events only go with the new event system. So probably @laoneo you could just do the same PR with the new event system?
Sorry for the trouble.