New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Add server timing response header in debug mode #36231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on cf42d70 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231. |
Maybe add a colon after each description for consistency. |
@Quy that's how it comes from the profiler. How would you do it then, can you make a suggestion? |
Quy
reviewed
Jan 20, 2022
Co-authored-by: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on 27300cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231. |
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Browsers do support a server timing header field which adds information what happens on the server side. This basically gives the developer insight what happens in the "Time to First Byte".
This pr adds the missing header in the debug plugin, as this header should not be added when in production mode because of performance reasons.
Would be nice to get some feedback about spicing up the values of the header as currently I'm just logging them as they are.
The view looks like in the following picture:
Testing Instructions
Actual result BEFORE applying this Pull Request
Only the request timing information is shown.
Expected result AFTER applying this Pull Request
Beside the request timing is the server timing information shown.