Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Make it Optional to Save Response from the GET Request Task Routine #36926

Open
wants to merge 8 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

ditsuke
Copy link
Contributor

@ditsuke ditsuke commented Feb 3, 2022

Addresses a concern from #36201.

Summary of Changes

  • Saving responses from the GET Request is now optional and disabled by default.
  • The saved result now uses the tmp_dir from the global configuration.

Testing Instructions

  • Make a task G1 with the GET Request routine, keep "Save Response" disabled.
  • Make another task G2 with "Save Response" enabled.
  • Trigger the tasks either by waiting or by manually running from the list view.

Actual result BEFORE applying this Pull Request

  • There is no option to not save the response.
  • Response is saved in the tmp/ directory blind to the tmp_dir configuration.

Expected result AFTER applying this Pull Request

  • There is an option to not save the response making retention opt-in. Response for the G1 task is not saved while response for the G2 task is saved.
  • tmp_dir configuration is respected.

Documentation Changes Required

nil

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Feb 3, 2022
@ditsuke ditsuke changed the title Make it Optional to Save Response from the GET Request Task Routine [4.1] Make it Optional to Save Response from the GET Request Task Routine Feb 3, 2022
Co-authored-by: Quy <quy@fluxbb.org>
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@HLeithner HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:06
@HLeithner
Copy link
Member

This pull request has automatically rebased to 4.2-dev.

@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev.

@MacJoom
Copy link
Contributor

MacJoom commented Aug 26, 2023

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

@MacJoom MacJoom added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 26, 2023
@HLeithner
Copy link
Member

Needs to updated, Call to undefined method Joomla\Component\Scheduler\Administrator\Table\TaskTable::getCurrentUser()

is fixed in 5.0 already, but this pr conflicts and has to be resolved

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:52
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:09
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [4.1] Make it Optional to Save Response from the GET Request Task Routine [5.2] Make it Optional to Save Response from the GET Request Task Routine Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators PBF Pizza, Bugs and Fun PR-5.0-dev PR-5.2-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants