Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail Cloak: part of the TLD will not be truncated #36985

Closed
wants to merge 1 commit into from

Conversation

shagungarg0
Copy link
Contributor

Pull Request for Issue #36981

###Summary Of Changes
$searchEmail = '([\w.'-+]+@(?:[a-z0-9.-]+.)+(?:[a-zA-Z0-9-]{2,10}))';
This accepts only 10 characters due to which some emails were not picked by server and hence people were facing problem.

Actual result BEFORE applying this Pull Request

Once the plugin(email-cloak) is activated, part of the TLD will be truncated. Example:
office@some.international
becomes:
office@some.internatio

Expected result AFTER applying this Pull Request

E-mail will not be truncated

@zero-24
Copy link
Contributor

zero-24 commented Feb 9, 2022

Hi, can you please send the PR against the 3.10 branch? After that it will be merged up to 4.1 and 4.2

From my understanding we should just remove the caracter limit for the domain part? Why do you want to change more things?

Maybe there is a regex from the rfc sonewhere?

@shagungarg0
Copy link
Contributor Author

Hi, can you please send the PR against the 3.10 branch? After that it will be merged up to 4.1 and 4.2

From my understanding we should just remove the caracter limit for the domain part? Why do you want to change more things?

Maybe there is a regex from the rfc sonewhere?

#36986

@zero-24
Copy link
Contributor

zero-24 commented Feb 9, 2022

Thanks

@richard67
Copy link
Member

Closing in favor of #36986 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants