[3.10] Privacy Consent wording I agree and No #37181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 1ab91f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37181. |
|
@zero-24 Do we really want to change that in 3.10? Or shouldn't that be moved to 4.1? Or maybe even 4.2? |
|
Its just a string change and it can be considered a bug fix so no reason (in my mind) for it not to go in a patch release. As for it going in 3.10 - its a bug fix not a feature so why not? |
richard67
changed the title
|
I have tested this item ✅ successfully on 1ab91f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37181. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37181. |
|
Merging here thanks. |
nibra
pushed a commit
to nibra/joomla-cms
that referenced
this pull request
Mar 22, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 26, 2022
joomla/joomla-cms#36969 + joomla/joomla-cms#36861 + joomla/joomla-cms#37181 + joomla/joomla-cms#37334 - (только для de-*) и другие правки из Joomla 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22198 .
Summary of Changes
see #22198
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
'No' is replaced by 'I do not agree'