Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Replace $this->_db usages in components models #38025

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR $this->_db in all components models by database object returned by getDatabase() method. This is not a find and replace PR, so please do careful code review before merging.

Testing Instructions

  1. Use Joomla 4.2
  2. Apply patch
  3. Access to random pages from both frontend and backend, make sure nothing is broken
  4. Please at least one careful code review.

@rdeutz
Copy link
Contributor

rdeutz commented Jun 10, 2022

I have tested this item ✅ successfully on 61d5341

Looks good to me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38025.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 61d5341


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38025.

@alikon
Copy link
Contributor

alikon commented Jun 10, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38025.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2022
@Quy Quy added the PR-4.2-dev label Jun 10, 2022
@roland-d roland-d merged commit 586c6d6 into joomla:4.2-dev Jun 12, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
@joomdonation joomdonation deleted the replace_db_property_in_models branch June 12, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants