Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Replace deprecated method getDbo() by getDatabase() #38023

Merged

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Simple find and replace PR to replace deprecated method getDbo() by getDatabase() in components models.

Testing Instructions

  1. Code review
  2. Or apply patch, access to random pages from frontend and backend, make sure nothing is broken.

@laoneo laoneo merged commit ca1d7e7 into joomla:4.2-dev Jun 10, 2022
@laoneo
Copy link
Member

laoneo commented Jun 10, 2022

Thanks! Would be good to also replace the ->_db usages.

@laoneo laoneo added this to the Joomla 4.2.0 milestone Jun 10, 2022
@joomdonation joomdonation deleted the user_getdatabase_in_component_models branch June 10, 2022 05:48
@brianteeman
Copy link
Contributor

has there been a policy about rquiring tests?

@joomdonation
Copy link
Contributor Author

Thanks! Would be good to also replace the ->_db usages.

@laoneo I made PR #38025 for that replacement.

heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Jun 19, 2022
roland-d pushed a commit that referenced this pull request Jun 20, 2022
* short array syntax

* Replace deprecated method getDbo() by getDatabase()

see #38023

* use whereIn

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants