Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request : surrounding the logo and the menu inside container + new class for logo #38204

Closed
sofianhit opened this issue Jul 2, 2022 · 5 comments

Comments

@sofianhit
Copy link

hi
this feature request can be instead of this feature request :
https://issues.joomla.org/tracker/joomla-cms/38192
or fulfillment both .

the idea here is to put the logo and the menu inside one div + adding a new class for logo .
We will get :
1- keep 100% width for topbar and below top .
2- keep topbar and below top sticky inside sticky header .
3- no need much works and changes from the developers .
4- PUT the logo and menu in one row without affect the topbar and below top (by own css).
5- by adding a new class for logo we can play with the width of the logo and menu inside their new container .
6- must add new class to logo because it has only "grid-child" class that is for topbar and below top too .

screen shot 2022-07-02 at 09 28 14

screen shot 2022-07-02 at 09 28 18

@richard67
Copy link
Member

So can #38192 be closed?

@sofianhit
Copy link
Author

maybe yes , maybe wait to hear another opinions .
like you want .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38204.

@ReLater
Copy link
Contributor

ReLater commented Jul 2, 2022

In a "Mobile first!" world I would like to see more mockups for different screen widths. And would like to hear some ideas how you want to realise them in a backwards compatible Cassiopeia.

Finally you're planning a new template somehow. Don't you think that would be the better way to realise your ideas? And less work? Or maybe it would be better to implement them in core as an additional child template?

@sofianhit
Copy link
Author

close this topic


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38204.

@richard67
Copy link
Member

Closing as stated by the author in the previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants