Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33906] New Media Manager for Joomla! CMS #3839

Closed
wants to merge 125 commits into from

Conversation

Buddhima
Copy link
Contributor

Hi All,
Let me introduce the new media manager for Joomla! along with this PR. With this project I have introduced 12 new things to Media Manager. I have constructed a document describing this project in detail.
The link for the document is : https://docs.google.com/document/d/1mZMwBU_hW7AshL5rkAdIyswQmzBmP1L8L1PdM093rB0/edit?usp=sharing
Feature Tracker Item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33906&start=0
This new Media Manager add entries to your database. Therefore I kindly request you to go through "Testing Instructions" at document before testing this.

Thank You!

image

@Buddhima
Copy link
Contributor Author

Hi All,

With recent commits I added video preview, and audio preview support for the new media manager. I believe it would help to provide better user experience.

Video Preview :
video_preview

Audio Preview :
audio_preview

Thank you!

@dgrammatiko
Copy link
Contributor

@Buddhima
Looking good!
Can you take a look at #5871 and also incorporate the changes I made there in the file controller.php here?

Also you are using mootools modal here, we are trying to render everything with bootstrap. I can make a PR changing that, if you want...

@Buddhima
Copy link
Contributor Author

@dgt41
I'll have a look at your implementation as well. I would appreciate if you can send a PR.
Thank you!

@dgrammatiko
Copy link
Contributor

@Buddhima will do that this weekend. Are there any other places where you use mootools modal?

@Buddhima
Copy link
Contributor Author

@dgt41 I don't think so, because I used bootstrap modals for Media Editor popups. For video & audio popups, they need to come-out-of iframe as well. At the moment I wasn't able to do with mootools.

@danielsmink
Copy link
Contributor

@Buddhima any idea when we can expect this to be merged? 3.5 or later? We need a more advanced Media manager for a project and this sounds exactly like what we need. But considering deadlines it might come to late.

@Buddhima
Copy link
Contributor Author

Buddhima commented Sep 8, 2015

Hi @danielsmink , According to the discussions above, it's sad to say that still this is not planned for Joomla! 3.5. For your case, you can take this and modify accordingly.

@N6REJ
Copy link
Contributor

N6REJ commented Sep 8, 2015

if its ready, why is it being stopped?
Bear
On 9/8/2015 02:58, Buddhima Wijeweera wrote:

Hi @danielsmink https://github.com/danielsmink , According to the
discussions above, it's sad to say that still this is not planned for
Joomla! 3.5. For your case, you can take this and modify accordingly.


Reply to this email directly or view it on GitHub
#3839 (comment).

@Bakual
Copy link
Contributor

Bakual commented Sep 8, 2015

if its ready, why is it being stopped?

It's not ready due to two main points. Those are code/architecture issues and not user interface issues.

It depends a lot on classes from com_config, which is a no-go.
It either has to

  • wait for the "new MVC" classes @wilsonge wanted to write, and then be rewritten to extend those,
  • rewite the whole thing to directly use the base classes for the "new MVC" in the library folders
  • or rewrite the whole thing to use the legacy MVC

It also still uses the UCM tables to store the data, which I would prefer when it would not do that. UCM as it is of today will likely be changed or even removed with J4. So we would face a rewrite then again.

@N6REJ
Copy link
Contributor

N6REJ commented Sep 8, 2015

damn, ok.

Bear
On 9/8/2015 09:32, Thomas Hunziker wrote:

if its ready, why is it being stopped?

It's not ready due to two main points. Those are code/architecture
issues and not user interface issues.

It depends a lot on classes from com_config, which is a no-go.
It either has to

  • wait for the "new MVC" classes @wilsonge
    https://github.com/wilsonge wanted to write, and then be
    rewritten to extend those,
  • rewite the whole thing to directly use the base classes for the
    "new MVC" in the library folders
  • or rewrite the whole thing to use the legacy MVC

It also still uses the UCM tables to store the data, which I would
prefer when it would not do that. UCM as it is of today will likely be
changed or even removed with J4. So we would face a rewrite then again.


Reply to this email directly or view it on GitHub
#3839 (comment).

@roland-d
Copy link
Contributor

roland-d commented Sep 8, 2015

Since this PR is never going to be merged as-is I am going to close it. @Buddhima thank you for your work and I will continue to work on trying to get features moved over into the Joomla core.

Those of you who want to work further with this code can go to Buddhimas' repo at: https://github.com/Buddhima/joomla-cms/tree/new_com_media

Thanks everybody for the feedback.

@roland-d roland-d closed this Sep 8, 2015
@holodyn
Copy link

holodyn commented Sep 28, 2015

Come on - obviously there are several considerations to this PR, but there is a tremendous amount of work put toward this product that would transform Joomla! usability. Merge this thing and let the community contribute to the updates afterwards rather than killing the momentum. Good job @Buddhima.

@micker
Copy link

micker commented Sep 28, 2015

yes dont kill this important feature all users need it

@javigomez
Copy link
Contributor

Just to clarify. Is not a close forever. Is just a delay. We really appreciate the work done here and we all what to see it happening soon.

@JoshJourney
Copy link

Any news on this?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3839.

@wilsonge
Copy link
Contributor

We're working on porting the features back into the existing MVC system here https://github.com/joomla-projects/media-manager-improvement but progress at the moment is reasonably slow. We are aiming to have most of the things from this PR ported into that for 3.6 in the next month or so however

@chrisdavenport
Copy link
Contributor

The latest code for this is here: https://github.com/jissereitsma/media-manager-improvement

If you have a little time to spare, please test and provide feedback. Thanks.

@N6REJ
Copy link
Contributor

N6REJ commented Apr 27, 2016

why two separate repos?

@brianteeman
Copy link
Contributor

Why just have one when you can have two or more ;)

@piotr-cz
Copy link
Contributor

It may be late suggestion, but are there any reasons for not creating just an extension repo, similar to joomla-extensions/weblinks?

@chrisdavenport
Copy link
Contributor

Because it's not a properly decoupled extension like weblinks.

@piotr-cz
Copy link
Contributor

From brief look at the diff, it looks like two changes preventing decoupling are:

The rest considers com_media or may be added as pull requests to Joomla core (JImage::flip, added CSS, drag'n'drop upload).

I'm interested in decoupling for testing purposes. IMHO this component is too tightly integrated with core to decouple it in sense of removing from distribution.

@Bakual
Copy link
Contributor

Bakual commented Apr 28, 2016

Imho, you can't decouple com_media. It's an extension like com_categories which always should be present. Various 3rd party extension will also depend on it being present (and be it only by using the formfield).
Personally speaking, I'd say it's wasted time trying to decouple the media manager.

@Fedik
Copy link
Member

Fedik commented Apr 28, 2016

from the theory point of view, it could be similar to Captcha:
Joomla itself provide just the "media" field, that display the input depend from which "Media manager" are default.

@piotr-cz
Copy link
Contributor

My motivation in decoupling is to be able to install new media manager snapshot in J3.5 installation (before it's released in J3.6, if it is).

As I've written before, I consider media manager as a core component, like com_config and for sure it shouldn't be distributed separately but developed atomically.

@brianteeman
Copy link
Contributor

You can just download and install the entire branch

On 28 April 2016 at 14:06, Piotr notifications@github.com wrote:

My motivation in decoupling is to be able to install new media manager
snapshot in J3.5 installation (before it's released in J3.6, if it is).

As I've written before, I consider media manager as a core component, like
com_config and for sure it shouldn't be distributed separately but
developed atomically.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3839 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet