Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child template language handling #38568

Closed
BrainforgeUK opened this issue Aug 23, 2022 · 5 comments
Closed

Child template language handling #38568

BrainforgeUK opened this issue Aug 23, 2022 · 5 comments

Comments

@BrainforgeUK
Copy link
Contributor

Steps to reproduce the issue

Create a child template from Cassiopeia
cassiopeia_mychildtemplate

Expected result

(a) If the language files tpl_cassiopeia_mychildtemplate.ini and tpl_cassiopeia_mychildtemplate.sys.ini are created and left blank I expected the text from tpl_cassiopeia.ini and tpl_cassiopeia.sys.ini to be used. I.E. the cassioperia text will be used by default, the child being able to overwrite / add more as needed.

(b) I expected to be able to place language files in templates/cassiopeia_mychildtemplate/language/en-GB folder. This being consistent with elsewhere where you can use either modules/mod_mymodule/language/en-GB/mod_mymodule.ini or language/en-GB/mod_mymodule.ini

(c) I expected to be able to translate the template name (cassiopeia_mychildtemplate) in the templateDetails.xml file with text in cassiopeia_mychildtemplate.sys.ini.

Actual result

(a) Have to duplicate all the cassiopeia text in the child language files. This will cause problems later when extra parameters / more text added to cassioperia - I would expect the child to inherit everything by default.

(b) Language files in templates/cassiopeia_mychildtemplate/language/en-GB folder are ignored.

(c) There appears to be no translation for the template name.

System information (as much as possible)

Joomla 4.2.0

Additional comments

@BrainforgeUK
Copy link
Contributor Author

Item (a) - Not leave tpl_cassiopeia_mychildtemplate.ini blank but put a single line in it ...

TPL_CASSIOPEIA_XML_DESCRIPTION="Cassiopeia child template for my site."

Can of course change TPL_CASSIOPEIA to TPL_CASSIOPEIA_MYCHILDTEMPLATE in both the .ini and .xml files, but that is not significant to this issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38568.

@brianteeman
Copy link
Contributor

duplicate of #38499 ?

@BrainforgeUK
Copy link
Contributor Author

Overlaps. This gives more detail of what needs to be investigated.

@brianteeman
Copy link
Contributor

Agreed. Maintainers please close the other issue and link it here
Please.

@alikon
Copy link
Contributor

alikon commented Aug 24, 2022

please test #38578

@alikon alikon closed this as completed Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants