Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child templates languages #38578

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Child templates languages #38578

merged 1 commit into from
Sep 6, 2022

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #38568.

Summary of Changes

  • respect the language cascade (eg the core templates don't use the default language folder in the root of the template directory)

Testing Instructions

  • Create a child of cassiopeia
  • Assign all the menu items to that template
  • copy the index.php to the child root folder
  • add <?= Text::_('TPL_CASSIOPEIA_XML_DESCRIPTION'); ?> after the <body> opening tag
  • check that the translated string is in the output
  • Repeat for the Atum

Screenshot 2022-08-24 at 10 51 34

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@alikon alikon mentioned this pull request Aug 24, 2022
Closed
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0db3293

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38578.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0db3293

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38578.

@alikon
Copy link
Contributor

alikon commented Aug 24, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38578.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2022
@wilsonge wilsonge merged commit c93e88c into joomla:4.2-dev Sep 6, 2022
@wilsonge
Copy link
Contributor

wilsonge commented Sep 6, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@dgrammatiko dgrammatiko deleted the patch-6 branch September 6, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla! 4.2.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dgrammatiko @brianteeman @viocassel @alikon @wilsonge @joomla-cms-bot