Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] fix var name in content table #39138

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Nov 2, 2022

Fix for Pull Request #37017 .

Summary of Changes

fix variable name: content table use state instead of published

Testing Instructions

  • try to create two articles with the same alias
  • the existing article is either published or trashed
  • check the error messages

Actual result BEFORE applying this Pull Request

error message COM_CONTENT_ERROR_UNIQUE_ALIAS_TRASHED="A trashed Article in this category has the same alias." will not appear

image

Expected result AFTER applying this Pull Request

error message COM_CONTENT_ERROR_UNIQUE_ALIAS_TRASHED="A trashed Article in this category has the same alias." will appear

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

content table use `state` instead of `published`
@alikon
Copy link
Contributor

alikon commented Nov 20, 2022

I have tested this item ✅ successfully on fa0c6e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39138.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on fa0c6e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39138.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39138.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 27, 2022
@fancyFranci fancyFranci merged commit daf658d into joomla:4.2-dev Dec 3, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 3, 2022
@fancyFranci fancyFranci added this to the Joomla! 4.2.6 milestone Dec 3, 2022
@fancyFranci
Copy link
Contributor

Always nice to get feedback from the system. Thank you!

@heelc29 heelc29 deleted the patch-37017 branch December 7, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants