[5.2] Tags: Adding associations #39140

Hackwar · 2022-11-02T20:52:42Z

Pull Request for Issue #6687 .

Summary of Changes

Tags in Joomla have so far partial support for multilanguage capabilities and there was partial, non-working code for associations. This PR introduces associations completely, cleans up the code around this and the multilanguage features are brought up to par with the rest of the Joomla core components.

When multilanguage is enabled, the views in the component now only show tags and content items for the current language and *.
The tag_list_language_filter option was removed, since it conflicts with how multilinguality works in all of the rest of Joomla. Now it automatically behaves like the rest when multilanguage is enabled.
The TagModel::save() method has been largely removed and replaced with the call to AdminModel::save(). The only thing that was kept was the rebuild of the nested set structure. The old code didn't have the code for associations included and I'm pretty sure some other stuff was missing here, too.
Tag associations aren't just one-on-one mappings, but there are cases where you have selected more than one tag per menu item. In that case, we have to find the association for each tag individually and then create a URL out of all those associated IDs combined. If in case of multiple tag IDs a tag doesn't have an associated tag, it will use the original tag to build the new URL. This assumes that such a tag will have * as language value.
The branch is based on the changes from [4.3] Rewriting com_tags router #39114. Please keep that PR open as well and test them separately! These changes are pretty large and if we push this all into one giant PR, this will never get tested and merged. That would be very unfortunate, so please keep it the way it is. This PR already is gigantic.
The component currently does not contain the Associations toolbar button.

Testing Instructions

Please first test the general functionality of tags. This means to create a few tags in the backend both via the component and by the input field in for example articles. Assign those tags to content items, create menu items in the frontend for these tags or the the "all tags" menu item type. Surf those pages in the frontend and check if everything is displayed correctly. Also create menu items with more than one tag selected for it.

In the next step, enable multilanguage mode and mark several content items with different content languages. Mark at least one tag as from one content language, create a second tag with another content language and associate these 2 tags. Check in the frontend that a tag view only shows content matching the current language and if you click on a flag, it should redirect to the associated tag.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

I don't know what we have to change here...

jamfx · 2022-11-03T17:13:07Z

I have tested this item 🔴 unsuccessfully on 0d7ed82

Ok, i tried the following and didn't succeed. The Test failed at least partly.
Steps I took.

Joomla Default Installation with Multilanguage Sample Data
Installed German and Greek languagepacks
Opened Tags and Translated Millions to Millionen for Association.
now set Millions to English and Millionen to German
Opened "Millions"-Tag and clicked on Associations. Now I wanted to choose Millionen and typed in "Mill" but only the item IDs showed up. I could save the IDs successfully, but after reopening nothing was shown in Associations.

I stopped the test here.
Thanks for your work so far!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39140.}

Hackwar · 2022-11-09T11:15:41Z

@jamfx I did some fixes. Please test this again.

administrator/components/com_tags/src/Helper/AssociationsHelper.php

administrator/components/com_tags/src/Model/TagModel.php

Quy · 2023-01-31T17:58:34Z

administrator/components/com_tags/tmpl/tag/edit.php

+$input = Factory::getApplication()->getInput();
+$params = clone $this->state->get('params');
+$assoc              = Associations::isEnabled();


Suggested change

$input = Factory::getApplication()->getInput();

$params = clone $this->state->get('params');

$assoc = Associations::isEnabled();

$input = Factory::getApplication()->getInput();

$params = clone $this->state->get('params');

$assoc = Associations::isEnabled();

Quy · 2023-01-31T17:59:13Z

components/com_content/tmpl/category/default_articles.php

@@ -34,20 +34,7 @@

 // Tags filtering based on language filter
 if (($this->params->get('filter_field') === 'tag') && (Multilanguage::isEnabled())) {
-    $tagfilter = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter');


Remove import.

Quy · 2023-01-31T18:00:09Z

components/com_tags/src/Model/TagsModel.php

@@ -119,16 +121,7 @@ protected function getListQuery()
        // Exclude the root.
        $query->where($db->quoteName('a.parent_id') . ' <> 0');

-        // Optionally filter on language
-        if (empty($language)) {
-            $language = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter', 'all');


Remove imports.

Quy · 2023-01-31T18:54:26Z

modules/mod_tags_similar/src/Helper/TagsSimilarHelper.php

@@ -146,14 +147,9 @@ public static function getList(&$params)
            ->bind(':nullDateDown', $nullDate)
            ->bind(':nowDateDown', $now);

-        // Optionally filter on language
-        $language = ComponentHelper::getParams('com_tags')->get('tag_list_language_filter', 'all');


Remove import.

Quy · 2023-01-31T18:54:48Z

modules/mod_tags_popular/src/Helper/TagsPopularHelper.php

@@ -13,6 +13,7 @@
 use Joomla\CMS\Component\ComponentHelper;


Suggested change

use Joomla\CMS\Component\ComponentHelper;

Quy · 2023-01-31T18:55:22Z

libraries/src/Helper/TagsHelper.php

@@ -11,6 +11,7 @@

 use Joomla\CMS\Component\ComponentHelper;


Suggested change

use Joomla\CMS\Component\ComponentHelper;

laoneo · 2023-03-28T07:57:37Z

Thank you for your contribution, unfortunately the 4.4-dev branch doesn't get new features. When #40181 is merged this pr should be rebased to 5.0-dev. Thanks for understanding.

…r.php Co-authored-by: Quy <quy@nomonkeybiz.com>

Co-authored-by: Quy <quy@nomonkeybiz.com>

Hackwar · 2023-03-28T08:28:07Z

Since I had to rebase this from 4.3 to 4.4 and now to 5.0, I first have to check all the changes here if they are still correct. Switching back to draft for now.

richard67 · 2023-04-18T12:20:29Z

Why closed? Should we reopen the original issue?

HLeithner · 2023-09-30T22:51:21Z

This pull request has been automatically rebased to 5.1-dev.

joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Nov 2, 2022

Hackwar marked this pull request as ready for review November 3, 2022 09:18

Hackwar mentioned this pull request Nov 3, 2022

Definetively resolve single tag redirect on multilanguage site #6687

Closed

This was referenced Nov 7, 2022

Tag view articles list not filtered by language even if the option is set #25998

Closed

com_tags layouts #39177

Open

Hackwar mentioned this pull request Nov 11, 2022

Tag links are pointing to a nonSEF URL in multilanguage mode #31530

Closed

Quy reviewed Jan 31, 2023

View reviewed changes

administrator/components/com_tags/src/Helper/AssociationsHelper.php Outdated Show resolved Hide resolved

Quy reviewed Jan 31, 2023

View reviewed changes

administrator/components/com_tags/src/Model/TagModel.php Outdated Show resolved Hide resolved

Quy reviewed Jan 31, 2023

View reviewed changes

Hackwar changed the base branch from 4.3-dev to 4.4-dev March 23, 2023 10:33

Hackwar changed the title ~~[4.3] Tags: Adding associations~~ [4.4] Tags: Adding associations Mar 23, 2023

joomla-cms-bot added the PR-4.4-dev label Mar 23, 2023

Quy removed the PR-4.3-dev label Mar 23, 2023

Hackwar changed the title ~~[4.4] Tags: Adding associations~~ [5.0] Tags: Adding associations Mar 28, 2023

Hackwar changed the base branch from 4.4-dev to 5.0-dev March 28, 2023 08:00

Hackwar requested review from laoneo, chmst, rdeutz, zero-24 and wilsonge as code owners March 28, 2023 08:00

Adding associations to tags

ad0feef

Hackwar added 7 commits March 28, 2023 10:22

Remove layout from query

1b2b79b

Fixing another bug

bda3013

Improving lookup method

747773a

Releasing restrictions on parameter

ab7ce5b

Cleanup

7be6565

Removing tag_list_language_filter option

741888a

Fix tag saving and add rebuild button

4e1fe44

Hackwar force-pushed the 4.3-tags-3 branch from 42dc554 to 4e1fe44 Compare March 28, 2023 08:24

joomla-cms-bot added the PR-5.0-dev label Mar 28, 2023

Hackwar and others added 2 commits March 28, 2023 10:25

Update administrator/components/com_tags/src/Helper/AssociationsHelpe…

aaa94bc

…r.php Co-authored-by: Quy <quy@nomonkeybiz.com>

Update administrator/components/com_tags/src/Model/TagModel.php

cc4d771

Co-authored-by: Quy <quy@nomonkeybiz.com>

Hackwar marked this pull request as draft March 28, 2023 08:27

MacJoom removed the PR-4.4-dev label Mar 28, 2023

HLeithner added the Feature label Apr 7, 2023

Hackwar closed this Apr 18, 2023

Hackwar reopened this Apr 18, 2023

HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:51

Merge branch '5.1-dev' into 4.3-tags-3

469c2dc

joomla-cms-bot added the PR-5.1-dev label Jan 4, 2024

Hackwar changed the title ~~[5.0] Tags: Adding associations~~ [5.2] Tags: Adding associations Apr 3, 2024

Hackwar changed the base branch from 5.1-dev to 5.2-dev April 3, 2024 15:25

Merge branch '5.2-dev' into 4.3-tags-3

fada876

joomla-cms-bot added the PR-5.2-dev label Apr 3, 2024

Quy added PR-5.2-dev and removed PR-5.2-dev PR-5.0-dev PR-5.1-dev labels Apr 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.2] Tags: Adding associations #39140

[5.2] Tags: Adding associations #39140

Hackwar commented Nov 2, 2022 •

edited

jamfx commented Nov 3, 2022

Hackwar commented Nov 9, 2022

Quy Jan 31, 2023

Quy Jan 31, 2023

Quy Jan 31, 2023

Quy Jan 31, 2023

Quy Jan 31, 2023

Quy Jan 31, 2023

laoneo commented Mar 28, 2023

Hackwar commented Mar 28, 2023

richard67 commented Apr 18, 2023

HLeithner commented Sep 30, 2023

[5.2] Tags: Adding associations #39140

Are you sure you want to change the base?

[5.2] Tags: Adding associations #39140

Conversation

Hackwar commented Nov 2, 2022 • edited

Summary of Changes

Testing Instructions

Link to documentations

jamfx commented Nov 3, 2022

Hackwar commented Nov 9, 2022

Quy Jan 31, 2023

Choose a reason for hiding this comment

Quy Jan 31, 2023

Choose a reason for hiding this comment

Quy Jan 31, 2023

Choose a reason for hiding this comment

Quy Jan 31, 2023

Choose a reason for hiding this comment

Quy Jan 31, 2023

Choose a reason for hiding this comment

Quy Jan 31, 2023

Choose a reason for hiding this comment

laoneo commented Mar 28, 2023

Hackwar commented Mar 28, 2023

richard67 commented Apr 18, 2023

HLeithner commented Sep 30, 2023

Hackwar commented Nov 2, 2022 •

edited