Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify send email copy checkbox in contact form #39252

Closed
wants to merge 1 commit into from

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issue #34757.
Probably not the best solution, but the only one a I can think at the moment.

This problem is related to #31218 and is something we need to reconsider for the next major Joomla version.

Summary of Changes

Modified the way the checkbox "send mail copy" is rendered. It uses now current Bootstrap code to display checkbox and label in a line.

Testing Instructions

See issue #34757

Actual result BEFORE applying this Pull Request

See issue #34757

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 6b61bf4

Thanks, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39252.

@brianteeman
Copy link
Contributor

The problem with this is that it only fixes this one field. If you have another checkbox type field on that page then you still get the problem.

From what I can tell it needs a display:inline-block on the .controls class

@drmenzelit
Copy link
Contributor Author

display:inline-block is not enough, because .controls is inside .control-group together with .control-label
If .control-group would have another unique class for the copy field, one could use display: flex ... but that is not the case, all fields have only .control-group...

@drmenzelit
Copy link
Contributor Author

Please check #39259

@chmst
Copy link
Contributor

chmst commented Nov 23, 2022

If you change your condition to

<?php if ($field->type != 'Checkbox') : ?>

the form can have many checkboxes.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev May 2, 2023 16:29
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.3-dev.

@obuisard obuisard changed the base branch from 4.3-dev to 5.0-dev July 15, 2023 18:59
@HLeithner
Copy link
Member

This functionally should be removed completely instead of fixing it. I close this PR since allowing the user to send emails to an arbitrary address is a security issue.

@HLeithner HLeithner closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.0-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants