-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify send email copy checkbox in contact form #39252
Conversation
I have tested this item ✅ successfully on 6b61bf4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39252. |
The problem with this is that it only fixes this one field. If you have another checkbox type field on that page then you still get the problem. From what I can tell it needs a display:inline-block on the .controls class |
display:inline-block is not enough, because .controls is inside .control-group together with .control-label |
Please check #39259 |
If you change your condition to
the form can have many checkboxes. |
This pull request has been automatically rebased to 4.3-dev. |
This functionally should be removed completely instead of fixing it. I close this PR since allowing the user to send emails to an arbitrary address is a security issue. |
Pull Request for Issue #34757.
Probably not the best solution, but the only one a I can think at the moment.
This problem is related to #31218 and is something we need to reconsider for the next major Joomla version.
Summary of Changes
Modified the way the checkbox "send mail copy" is rendered. It uses now current Bootstrap code to display checkbox and label in a line.
Testing Instructions
See issue #34757
Actual result BEFORE applying this Pull Request
See issue #34757
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed