[Contact] Send email copy - change field type to checkboxes #39259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmenzelit
changed the title
4 tasks
|
In addition to the fact that the checkbox itself, depending on the filling or not, directly says Yes / No (a real tautology), I would vote for the previous solution. In addition, at least one more checkbox can be in contacts with a fairly high frequency - a privacy policy, the visual solution of which corresponds to PR #39252 and does NOT correspond to this PR. |
|
This pull request has been automatically rebased to 4.3-dev. |
|
This functionally should be removed completely instead of fixing it. I close this PR since allowing the user to send emails to an arbitrary address is a security issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #34757
Maybe a better solution than #39252
Summary of Changes
Modified field type to checkboxes
Testing Instructions
See issue #34757
Actual result BEFORE applying this Pull Request
See issue #34757
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed