Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fix #36345, TinyMCE, make sure iframe is fully loaded #39686

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 21, 2023

Pull Request for Issue #36345 for fix #24343

Summary of Changes

Make sure the script listen iframe load event only once.

Testing Instructions

Apply patch, run npm install

Create subform with editor (example in Custom HTML):

<field type="subform" name="subform" multiple="true" label="subform">
  <form>
    <field type="editor" name="text" label="editor" buttons="false"  default="I am a text!"/>
  </form>
</field>

Run test in Chrome and Firefox, and Safari (if you have one).

Make sure the Article content editor works correctly.

Then add couple rows in subform and try sort them. Then watch editor content.

Actual result BEFORE applying this Pull Request

In Firefox the Article content editor realods itself, and not able to edit content.

Expected result AFTER applying this Pull Request

In all Browsers the content editor works correctly.
Content in subform editor works after sorting.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jan 21, 2023
@Fedik
Copy link
Member Author

Fedik commented Jan 21, 2023

@Quy please test

@Quy
Copy link
Contributor

Quy commented Jan 21, 2023

I have tested this item ✅ successfully on d4de355

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.

@richard67
Copy link
Member

I have tested this item ✅ successfully on d4de355


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 21, 2023
@fancyFranci fancyFranci merged commit d3b6e9f into joomla:4.2-dev Jan 22, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2023
@fancyFranci
Copy link
Contributor

Thank you for fixing the fix :)

@fancyFranci fancyFranci added this to the Joomla! 4.2.7 milestone Jan 22, 2023
@Fedik Fedik deleted the tinymce-sort-fix5 branch January 22, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Subform)Repeatable editor blank after drag&drop reorder
5 participants