Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelogurl not set in #__extensions when package updated #40056

Open
Ruud68 opened this issue Mar 9, 2023 · 3 comments
Open

Changelogurl not set in #__extensions when package updated #40056

Ruud68 opened this issue Mar 9, 2023 · 3 comments

Comments

@Ruud68
Copy link
Contributor

Ruud68 commented Mar 9, 2023

Steps to reproduce the issue

  1. When you have a package installed that didn't have a changelogurl set in the manifest file and you upgrade that package with a version that does have a changelogurl set in the manifest, this changelogurl is not stored in that database.
  2. when you change the changelogurl in your package and install this updated package, the changelogurl is still the old one > so not updated

currently changelogurl is only set (and thus used) on newly installed packages. The changelog button is showed, but when clicked there is not url set to get the contents from (and displays an empty popup)

Expected result

changelogurl field in table #__extensions for packages should be updated to (new) changelogurl

Actual result

changelogurl field in table #__extensions for packages is not updated

System information (as much as possible)

Additional comments

workaround is to set it manually via a install script on updating the package.

@joomdonation
Copy link
Contributor

@Ruud68 You made PR #35794 to address this issue before. Sadly It was not merged because there were not enough testing

Could you please redo the PR? Maybe this time for package extension only and provide a sample package for testing? I will test it myself and find someone from Bug Squash team to test it, too to make sure the issue sorted. Thanks.

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 9, 2023

Hi @joomdonation thanks for following up. I reported this issue here because I have customers complaining about it and now I can refer them to where the bug actually is.
For my own packages I have a workaround in place.
Reporting the issue here is the most I can do currently.

@joomdonation
Copy link
Contributor

I was hoping you could make the PR, but that's OK. We will try to fix it ASAP.

@Hackwar Hackwar added the bug label Mar 9, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@brianteeman brianteeman removed the PBF Pizza, Bugs and Fun label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants