Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours Caption [a11y] #40214

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Mar 26, 2023

The key used for the caption was incorrect resulting in an untranslated string.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

The key used for the caption was incorrect resulting in an untranslated string.
@richard67
Copy link
Member

@brianteeman The diff on GitHub shows a lot more changes than just the language string key.

@brianteeman
Copy link
Contributor Author

@richard67 stupid ide - fixing

@Quy
Copy link
Contributor

Quy commented Mar 26, 2023

There isn't a language string for it, but this should be List of Steps.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 27, 2023
@brianteeman
Copy link
Contributor Author

There isn't a language string for it, but this should be List of Steps.

good spot - updated the pr now

@Quy
Copy link
Contributor

Quy commented Mar 27, 2023

I have tested this item ✅ successfully on c734339


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Mar 27, 2023

I have tested this item ✅ successfully on c734339


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 27, 2023
@obuisard obuisard merged commit 7d56184 into joomla:4.3-dev Mar 27, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2023
@obuisard
Copy link
Contributor

Thank you Brian @brianteeman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants