-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Guided Tours Caption [a11y] #40214
Conversation
The key used for the caption was incorrect resulting in an untranslated string.
@brianteeman The diff on GitHub shows a lot more changes than just the language string key. |
@richard67 stupid ide - fixing |
There isn't a language string for it, but this should be |
good spot - updated the pr now |
I have tested this item ✅ successfully on c734339 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214. |
1 similar comment
I have tested this item ✅ successfully on c734339 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214. |
Thank you Brian @brianteeman ! |
The key used for the caption was incorrect resulting in an untranslated string.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed