Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Updating joomla/filesystem to fix File::write() issue #40515

Merged
merged 2 commits into from Jun 9, 2023

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 30, 2023

Pull Request for Issue #40503.

Summary of Changes

This fixes the issue from #40503 by applying the fix that was made in the CMS 6 years ago to the framework as well... For reference: #11952
I applied that fix to the framework package and now the CMS needs to update its dependencies to pull those new changes. The fix for 4.4-dev will be upmerged sometime soon, I guess.

@richard67
Copy link
Member

I have tested this item ✅ successfully on aff15fa

Important hint for other testers:

When having done the test without the patch to reproduce the issue, you should either delete the session cookie with your broswer's developer tools or close the browser window to make sure that the browser session is cleared before testing the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40515.

@ChristineWk
Copy link

I have tested this item ✅ successfully on aff15fa

With Prebuilt Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40515.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40515.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 1, 2023
@richard67 richard67 added the bug label May 1, 2023
….0-dependency-filesystem

# Conflicts:
#	composer.lock
@HLeithner HLeithner merged commit 83b3053 into joomla:5.0-dev Jun 9, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 9, 2023
@HLeithner
Copy link
Member

Thx

@Hackwar Hackwar deleted the 5.0-dependency-filesystem branch March 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants